[PR #54] [MERGED] Binary search for dictionary #946

Open
opened 2026-01-29 16:57:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/54
Author: @anshul1912
Created: 6/25/2014
Status: Merged
Merged: 7/1/2014
Merged by: @cfsmp3

Base: masterHead: master


📝 Commits (1)

  • c8f65bb Binary search for dictionary

📊 Changes

6 files changed (+94 additions, -70 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 src/608_helpers.c (+26 -34)
📝 src/dvb_subtitle_decoder.c (+18 -35)
📝 src/params.c (+5 -1)
📝 src/utility.c (+40 -0)
📝 src/utility.h (+3 -0)

📄 Description

  1. Ignored Binary file *.sdf *.suo, since they are automatically created by visual studio.
  2. had to rewrite correct_case function minor tweaks were not possible.
  3. Using Shell short since I found it to be least time complexity O(n ^ 4/3) for our case and it has better performance then quick sort in terms of time complexity. for detail http://www.sorting-algorithms.com/

4)I have reused shell_sort from quantization logic in dvb_subtile so had to remove some dependency in dvb_subtitle
5) removed ISSEPARATOR, since it was used nowhere other then correct_case
6) tested on windows and linux using the.tudors.208-ALANiS.ts


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/54 **Author:** [@anshul1912](https://github.com/anshul1912) **Created:** 6/25/2014 **Status:** ✅ Merged **Merged:** 7/1/2014 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c8f65bb`](https://github.com/CCExtractor/ccextractor/commit/c8f65bb6862bf9d4b9367f1f42cf99d80129726e) Binary search for dictionary ### 📊 Changes **6 files changed** (+94 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `src/608_helpers.c` (+26 -34) 📝 `src/dvb_subtitle_decoder.c` (+18 -35) 📝 `src/params.c` (+5 -1) 📝 `src/utility.c` (+40 -0) 📝 `src/utility.h` (+3 -0) </details> ### 📄 Description 1) Ignored Binary file *.sdf *.suo, since they are automatically created by visual studio. 2) had to rewrite correct_case function minor tweaks were not possible. 3) Using Shell short since I found it to be least time complexity O(n ^ 4/3) for our case and it has better performance then quick sort in terms of time complexity. for detail http://www.sorting-algorithms.com/ 4)I have reused shell_sort from quantization logic in dvb_subtile so had to remove some dependency in dvb_subtitle 5) removed ISSEPARATOR, since it was used nowhere other then correct_case 6) tested on windows and linux using the.tudors.208-ALANiS.ts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:57:33 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#946