starred/dotnet-packaging
1
0
Fork 0
mirror of https://github.com/quamotion/dotnet-packaging.git synced 2026-02-14 13:45:53 +00:00
Code Issues 207 Packages Projects Releases Wiki Activity

Small inconsistency in logging #116

New Issue
Open
opened 2026-01-29 16:29:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:29:55 +00:00
Owner
Copy Link

Originally created by @FRvanderVeen on GitHub (Feb 22, 2022).

I was using the CreateDeb and CreateRpm tasks after each other. I noticed a small inconsistency in the logging output. This gave me the idea that something went wrong, but looking in the code, I see everything is fine.

Only the DebTask logs the following
3f7bd3c61a/Packaging.Targets/DebTask.cs (L192-L196)

3f7bd3c61a/Packaging.Targets/DebTask.cs (L288-L292)

Where all other tasks log
3f7bd3c61a/Packaging.Targets/RpmTask.cs (L260)

3f7bd3c61a/Packaging.Targets/RpmTask.cs (L336)

This difference is probably due to the fact that all other tasks write a log via the .targets file

Deb:
3f7bd3c61a/Packaging.Targets/build/Packaging.Targets.targets (L186-L190)

Rpm:
3f7bd3c61a/Packaging.Targets/build/Packaging.Targets.targets (L99-L105)

Originally created by @FRvanderVeen on GitHub (Feb 22, 2022). I was using the CreateDeb and CreateRpm tasks after each other. I noticed a small inconsistency in the logging output. This gave me the idea that something went wrong, but looking in the code, I see everything is fine. Only the DebTask logs the following https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/DebTask.cs#L192-L196 https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/DebTask.cs#L288-L292 Where all other tasks log https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/RpmTask.cs#L260 https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/RpmTask.cs#L336 This difference is probably due to the fact that all other tasks write a log via the .targets file Deb: https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/build/Packaging.Targets.targets#L186-L190 Rpm: https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/build/Packaging.Targets.targets#L99-L105
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pending-validation
pull-request
Mirrored from GitHub Pull Request
 up-for-grabs
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?