[PR #10] [MERGED] Minor RPM fixes #164

Open
opened 2026-01-29 16:30:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/10
Author: @qmfrederik
Created: 9/5/2017
Status: Merged
Merged: 9/5/2017
Merged by: @qmfrederik

Base: masterHead: fixes/rpm-no-dependencies


📝 Commits (2)

  • 2e6db26 Fix a null reference exception when RpmDependencies is null (i.e. the user did not specify any RPM package dependencies)
  • 34a4123 Use the AssemblyFileVersion for the package version, but default to 1.0.0.0 if it's not available.

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 Packaging.Targets/RpmTask.cs (+5 -1)
📝 Packaging.Targets/build/Packaging.Targets.targets (+5 -1)

📄 Description

  • Don't crash when no RPM dependencies have been specified
  • Use 1.0.0.0 as the package version when the AssemblyFileVersion is not set.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/10 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 9/5/2017 **Status:** ✅ Merged **Merged:** 9/5/2017 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `fixes/rpm-no-dependencies` --- ### 📝 Commits (2) - [`2e6db26`](https://github.com/quamotion/dotnet-packaging/commit/2e6db26e83bc63683a7d3414a0c3416b137923b5) Fix a null reference exception when RpmDependencies is null (i.e. the user did not specify any RPM package dependencies) - [`34a4123`](https://github.com/quamotion/dotnet-packaging/commit/34a4123ec5379a7e9377ed7424991303c179106d) Use the AssemblyFileVersion for the package version, but default to 1.0.0.0 if it's not available. ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Packaging.Targets/RpmTask.cs` (+5 -1) 📝 `Packaging.Targets/build/Packaging.Targets.targets` (+5 -1) </details> ### 📄 Description - Don't crash when no RPM dependencies have been specified - Use 1.0.0.0 as the package version when the AssemblyFileVersion is not set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:30:56 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#164