[PR #9] [MERGED] Fix netstandard2.0 compatibility #166

New Issue

claunia · 2026-01-29T16:30:56Z

claunia commented

2026-01-29 16:30:56 +00:00

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/9
Author: @qmfrederik
Created: 9/5/2017
Status: ✅ Merged
Merged: 9/5/2017
Merged by: @qmfrederik

Base: master ← Head: features/dotnet-2.0

📝 Commits (8)

bc89a09 Bump version numbers, build for netstandard2.0 as well.
52299c1 Fix typo
9d52fcb Fix typo
bb07577 Explicit version numbers for some dependencies
1c97385 Use private dependencies
9d8a1d7 Fix test project
8eb8fe0 Fix path to bouncy castle & sharpziplib dependencies
52aa413 Use netstandard2.0 Portable.BouncyCastle for netstandard2.0

📊 Changes

2 files changed (+34 additions, -8 deletions)

View changed files

📝 Packaging.Targets.Tests/Packaging.Targets.Tests.csproj (+3 -0)
📝 Packaging.Targets/Packaging.Targets.csproj (+31 -8)

📄 Description

Mark the MSBuild, SharpZipLib and BouncyCastle dependencies as Private, so they don't show up as a NuGet dependency
Include the SharpZipLib and BouncyCastle assemblies in the Packaging.Targets NuGet package, so they don't need to be acquired separately. We can ignore this for the MSBuild dependencies as they are already available on the build systems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/9 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 9/5/2017 **Status:** ✅ Merged **Merged:** 9/5/2017 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `features/dotnet-2.0` --- ### 📝 Commits (8) - [`bc89a09`](https://github.com/quamotion/dotnet-packaging/commit/bc89a09d23604866d59cedff64ec146c686910c5) Bump version numbers, build for netstandard2.0 as well. - [`52299c1`](https://github.com/quamotion/dotnet-packaging/commit/52299c1495a2dfb6e48626ea72f625d98fa9ba7a) Fix typo - [`9d52fcb`](https://github.com/quamotion/dotnet-packaging/commit/9d52fcb0cda59c596fd9d0cacbac48e9eb9561ba) Fix typo - [`bb07577`](https://github.com/quamotion/dotnet-packaging/commit/bb0757768750adb37bd3d3efc747c73341725099) Explicit version numbers for some dependencies - [`1c97385`](https://github.com/quamotion/dotnet-packaging/commit/1c97385fe8a7a74f2ba4e7c5dc9197d480841eb4) Use private dependencies - [`9d8a1d7`](https://github.com/quamotion/dotnet-packaging/commit/9d8a1d7fb0bf92d4634f6fdf083c85198fb5cb75) Fix test project - [`8eb8fe0`](https://github.com/quamotion/dotnet-packaging/commit/8eb8fe024feb8547c80e03d35971558f18824738) Fix path to bouncy castle & sharpziplib dependencies - [`52aa413`](https://github.com/quamotion/dotnet-packaging/commit/52aa4131aaa1aeaca0b2abfbdf26f1c9e18190aa) Use netstandard2.0 Portable.BouncyCastle for netstandard2.0 ### 📊 Changes **2 files changed** (+34 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `Packaging.Targets.Tests/Packaging.Targets.Tests.csproj` (+3 -0) 📝 `Packaging.Targets/Packaging.Targets.csproj` (+31 -8) </details> ### 📄 Description - Mark the MSBuild, SharpZipLib and BouncyCastle dependencies as Private, so they don't show up as a NuGet dependency - Include the SharpZipLib and BouncyCastle assemblies in the Packaging.Targets NuGet package, so they don't need to be acquired separately. We can ignore this for the MSBuild dependencies as they are already available on the build systems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:30:56 +00:00

claunia referenced this issue

2026-01-29 16:31:48 +00:00

[PR #166] [MERGED] Build and test in Windows, too #279

claunia referenced this issue

2026-01-29 16:31:49 +00:00

[PR #166] Build and test in Windows, too #283

Sign in to join this conversation.