[PR #23] [MERGED] Various fixed based on user feedback #173

New Issue

claunia · 2026-01-29T16:30:59Z

claunia commented

2026-01-29 16:30:59 +00:00

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/23
Author: @qmfrederik
Created: 10/11/2017
Status: ✅ Merged
Merged: 10/11/2017
Merged by: @qmfrederik

Base: master ← Head: fixes/rhel

📝 Commits (7)

164d5ee Add Vagrant box for testing on RHEL
555c5ad More work on a RHEL box
348b28c Support multiple names for the same library (e.g. liblzma.so with version suffixes on Linux)
0c16d05 Mark StyleCop as a private asset, limit System.* dependencies to netstandard1.5
da9ba23 Use libdl.so.2 on Linux instead of libd.so, use libdl.dylib on mac.
f3a0ba0 Use $(Version) to determine the $(PackageVersion) and use $(PackageVersion) in the $(PackageName) variable
2217be1 Add Fedora 25 box

📊 Changes

10 files changed (+303 additions, -103 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 Packaging.Targets/IO/NativeMethods.cs (+70 -50)
➕ Packaging.Targets/Native/FunctionLoader.cs (+128 -0)
➕ Packaging.Targets/Native/LinuxNativeMethods.cs (+18 -0)
➕ Packaging.Targets/Native/MacNativeMethods.cs (+18 -0)
📝 Packaging.Targets/Native/WindowsNativeMethods.cs (+5 -47)
📝 Packaging.Targets/Packaging.Targets.csproj (+8 -1)
📝 Packaging.Targets/build/Packaging.Targets.targets (+7 -5)
➕ boxes/fedora.25/Vagrantfile (+17 -0)
➕ boxes/rhel7.3/Vagrantfile (+31 -0)

📄 Description

Better compatibility with different Linux distributions: P/Invoke libdl.so.2 instead of libdl.so, and load libzlma with and without the .5 version suffix
Use $(Version) instead of $(AssemblyFileVersion) as the input to the package version; this property defaults to 1.0.0 on .NET Core so we don't get empty values
Make StyleCop a private asset, so dependent projects are not forced to use StyleCop
Add Vagrant boxes for RHEL and Fedora for testing purposes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/23 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 10/11/2017 **Status:** ✅ Merged **Merged:** 10/11/2017 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `fixes/rhel` --- ### 📝 Commits (7) - [`164d5ee`](https://github.com/quamotion/dotnet-packaging/commit/164d5eebd0a3ef2cb951fd185ea9dd4aefa72d4e) Add Vagrant box for testing on RHEL - [`555c5ad`](https://github.com/quamotion/dotnet-packaging/commit/555c5adf78bc3ad844cec1dca6e80c12004d45dc) More work on a RHEL box - [`348b28c`](https://github.com/quamotion/dotnet-packaging/commit/348b28c015067fe300f7756ad2e12275a1550e88) Support multiple names for the same library (e.g. liblzma.so with version suffixes on Linux) - [`0c16d05`](https://github.com/quamotion/dotnet-packaging/commit/0c16d05060a5aca3845f83d313e187f4fe8a7efd) Mark StyleCop as a private asset, limit System.* dependencies to netstandard1.5 - [`da9ba23`](https://github.com/quamotion/dotnet-packaging/commit/da9ba23d72d11ef3c4bc2cd28d02e05252b17557) Use libdl.so.2 on Linux instead of libd.so, use libdl.dylib on mac. - [`f3a0ba0`](https://github.com/quamotion/dotnet-packaging/commit/f3a0ba012b60cb7f1b2e7454f01c3f3b4d8741cb) Use $(Version) to determine the $(PackageVersion) and use $(PackageVersion) in the $(PackageName) variable - [`2217be1`](https://github.com/quamotion/dotnet-packaging/commit/2217be13af6bd4c19f3d7cb97bb844ac21573138) Add Fedora 25 box ### 📊 Changes **10 files changed** (+303 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `Packaging.Targets/IO/NativeMethods.cs` (+70 -50) ➕ `Packaging.Targets/Native/FunctionLoader.cs` (+128 -0) ➕ `Packaging.Targets/Native/LinuxNativeMethods.cs` (+18 -0) ➕ `Packaging.Targets/Native/MacNativeMethods.cs` (+18 -0) 📝 `Packaging.Targets/Native/WindowsNativeMethods.cs` (+5 -47) 📝 `Packaging.Targets/Packaging.Targets.csproj` (+8 -1) 📝 `Packaging.Targets/build/Packaging.Targets.targets` (+7 -5) ➕ `boxes/fedora.25/Vagrantfile` (+17 -0) ➕ `boxes/rhel7.3/Vagrantfile` (+31 -0) </details> ### 📄 Description - Better compatibility with different Linux distributions: P/Invoke `libdl.so.2` instead of `libdl.so`, and load `libzlma` with and without the `.5` version suffix - Use `$(Version)` instead of `$(AssemblyFileVersion)` as the input to the package version; this property defaults to `1.0.0` on .NET Core so we don't get empty values - Make StyleCop a private asset, so dependent projects are not forced to use StyleCop - Add Vagrant boxes for RHEL and Fedora for testing purposes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:30:59 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#173