[PR #74] [MERGED] RPM: Only flag files in /usr/share/doc as Doc #219

New Issue

claunia · 2026-01-29T16:31:19Z

claunia commented

2026-01-29 16:31:19 +00:00

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/74
Author: @qmfrederik
Created: 8/31/2018
Status: ✅ Merged
Merged: 8/31/2018
Merged by: @qmfrederik

Base: master ← Head: fixes/rpm-doc-files

📝 Commits (3)

c47ecd0 Only mark files in "/usr/share/doc" as documentation files
5e80a6f Update Docker files with fixes for RPM packages
03a32b1 Skip distros for which we don't specify libicu dependencies

📊 Changes

5 files changed (+505 additions, -7 deletions)

View changed files

📝 .travis.yml (+6 -4)
📝 Packaging.Targets/Rpm/FileAnalyzer.cs (+1 -3)
📝 demo/cliscd/centos.7-x64/reference.txt (+166 -0)
📝 demo/cliscd/fedora.28-x64/reference.txt (+166 -0)
📝 demo/cliscd/ol.7-x64/reference.txt (+166 -0)

📄 Description

We used a fairly odd heuristic to determine which files are flagged as 'documentation' in RPM packages. This caused most non-executable files to be marked as docs. This would include, say, the .NET assemblies and any HTML/js/css/... artifacts for ASP.NET Core apps.

By default, most distro's will not install documentation files in containers, and this change would cause the resulting installation to be unusable (because, for example, the .NET assemblies are missing).

This PR fixes that.

Fixes #61

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/74 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 8/31/2018 **Status:** ✅ Merged **Merged:** 8/31/2018 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `fixes/rpm-doc-files` --- ### 📝 Commits (3) - [`c47ecd0`](https://github.com/quamotion/dotnet-packaging/commit/c47ecd02f12eec03e5c4e85ebcb429b5220496ed) Only mark files in "/usr/share/doc" as documentation files - [`5e80a6f`](https://github.com/quamotion/dotnet-packaging/commit/5e80a6fcc2ad01e2295befabf5bf0082ba5fb586) Update Docker files with fixes for RPM packages - [`03a32b1`](https://github.com/quamotion/dotnet-packaging/commit/03a32b17587459de257fb674c58a5faa6968b88e) Skip distros for which we don't specify libicu dependencies ### 📊 Changes **5 files changed** (+505 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+6 -4) 📝 `Packaging.Targets/Rpm/FileAnalyzer.cs` (+1 -3) 📝 `demo/cliscd/centos.7-x64/reference.txt` (+166 -0) 📝 `demo/cliscd/fedora.28-x64/reference.txt` (+166 -0) 📝 `demo/cliscd/ol.7-x64/reference.txt` (+166 -0) </details> ### 📄 Description We used a fairly odd heuristic to determine which files are flagged as 'documentation' in RPM packages. This caused most non-executable files to be marked as docs. This would include, say, the .NET assemblies and any HTML/js/css/... artifacts for ASP.NET Core apps. By default, most distro's will not install documentation files in containers, and this change would cause the resulting installation to be unusable (because, for example, the .NET assemblies are missing). This PR fixes that. Fixes #61 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:31:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#219