[PR #120] [MERGED] Bump SourceLink version #237

New Issue

claunia · 2026-01-29T16:31:29Z

claunia commented

2026-01-29 16:31:29 +00:00

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/120
Author: @qmfrederik
Created: 11/21/2019
Status: ✅ Merged
Merged: 11/21/2019
Merged by: @qmfrederik

Base: master ← Head: fixes/sourcelink

📝 Commits (1)

2cb1ea9 Use Directory.Build.props for common properties & items

📊 Changes

6 files changed (+18 additions, -55 deletions)

View changed files

➕ Directory.Build.props (+18 -0)
📝 Packaging.Targets/Packaging.Targets.csproj (+0 -7)
📝 dotnet-deb/dotnet-deb.csproj (+0 -12)
📝 dotnet-rpm/dotnet-rpm.csproj (+0 -12)
📝 dotnet-tarball/dotnet-tarball.csproj (+0 -12)
📝 dotnet-zip/dotnet-zip.csproj (+0 -12)

📄 Description

It looks like using a new version of NerdBank.GitVersioning and using SourceLink cases the package version for Packaging.Targets to sometime miss the git qualifier.

This will case package restore to fail in subsequent steps.

Revert that change, and as a simplification, move a bunch of shared properties to Directory.Build.props

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/120 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 11/21/2019 **Status:** ✅ Merged **Merged:** 11/21/2019 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `fixes/sourcelink` --- ### 📝 Commits (1) - [`2cb1ea9`](https://github.com/quamotion/dotnet-packaging/commit/2cb1ea91028c5f08aff6237236b74576751a1bdb) Use Directory.Build.props for common properties & items ### 📊 Changes **6 files changed** (+18 additions, -55 deletions) <details> <summary>View changed files</summary> ➕ `Directory.Build.props` (+18 -0) 📝 `Packaging.Targets/Packaging.Targets.csproj` (+0 -7) 📝 `dotnet-deb/dotnet-deb.csproj` (+0 -12) 📝 `dotnet-rpm/dotnet-rpm.csproj` (+0 -12) 📝 `dotnet-tarball/dotnet-tarball.csproj` (+0 -12) 📝 `dotnet-zip/dotnet-zip.csproj` (+0 -12) </details> ### 📄 Description It looks like using a new version of NerdBank.GitVersioning and using SourceLink cases the package version for Packaging.Targets to sometime miss the git qualifier. This will case package restore to fail in subsequent steps. Revert that change, and as a simplification, move a bunch of shared properties to Directory.Build.props --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:31:29 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#237