starred/dotnet-packaging
1
0
Fork 0
mirror of https://github.com/quamotion/dotnet-packaging.git synced 2026-02-15 05:35:56 +00:00
Code Issues 207 Packages Projects Releases Wiki Activity

[PR #120] Bump SourceLink version #239

New Issue
Closed
opened 2026-01-29 16:31:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:31:30 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/quamotion/dotnet-packaging/pull/120

State: closed
Merged: Yes

It looks like using a new version of NerdBank.GitVersioning and using SourceLink cases the package version for Packaging.Targets to sometime miss the git qualifier.

This will case package restore to fail in subsequent steps.

Revert that change, and as a simplification, move a bunch of shared properties to Directory.Build.props

**Original Pull Request:** https://github.com/quamotion/dotnet-packaging/pull/120 **State:** closed **Merged:** Yes --- It looks like using a new version of NerdBank.GitVersioning and using SourceLink cases the package version for Packaging.Targets to sometime miss the git qualifier. This will case package restore to fail in subsequent steps. Revert that change, and as a simplification, move a bunch of shared properties to Directory.Build.props
claunia added the pull-request label 2026-01-29 16:31:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pending-validation
pull-request
Mirrored from GitHub Pull Request
 up-for-grabs
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?