starred/dotnet-packaging
1
0
Fork 0
mirror of https://github.com/quamotion/dotnet-packaging.git synced 2026-02-14 21:32:52 +00:00
Code Issues 207 Packages Projects Releases Wiki Activity

[PR #139] [MERGED] Warn when files are ignored #257

New Issue
Closed
opened 2026-01-29 16:31:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:31:39 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/139
Author: @qmfrederik
Created: 12/4/2019
Status: ✅ Merged
Merged: 12/5/2019
Merged by: @qmfrederik

Base: master ← Head: fixes/warn-when-file-ignored

📝 Commits (1)

  • f18d515 Log a warning when empty or hidden files are ignored

📊 Changes

9 files changed (+66 additions, -6 deletions)

View changed files

📝 Packaging.Targets/ArchiveBuilder.cs (+19 -2)
📝 Packaging.Targets/DebTask.cs (+5 -1)
📝 Packaging.Targets/RpmTask.cs (+5 -1)
📝 Packaging.Targets/TarballTask.cs (+5 -1)
➕ molecule/empty (+0 -0)
📝 molecule/framework-dependent/framework-dependent-app/framework-dependent-app.csproj (+6 -1)
📝 molecule/framework-dependent/molecule/default/tests/test_default.py (+10 -0)
📝 molecule/self-contained/molecule/default/tests/test_default.py (+10 -0)
📝 molecule/self-contained/self-contained-app/self-contained-app.csproj (+6 -0)

📄 Description

Hidden and empty files are ignored because they generate rpmlint errors.

Make sure the user knows about this, by generate a MSBuild warning.

Fixes #60

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/139 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 12/4/2019 **Status:** ✅ Merged **Merged:** 12/5/2019 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `fixes/warn-when-file-ignored` --- ### 📝 Commits (1) - [`f18d515`](https://github.com/quamotion/dotnet-packaging/commit/f18d515fe0d04d6f0d79780b8e24eb7ad836e0bd) Log a warning when empty or hidden files are ignored ### 📊 Changes **9 files changed** (+66 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Packaging.Targets/ArchiveBuilder.cs` (+19 -2) 📝 `Packaging.Targets/DebTask.cs` (+5 -1) 📝 `Packaging.Targets/RpmTask.cs` (+5 -1) 📝 `Packaging.Targets/TarballTask.cs` (+5 -1) ➕ `molecule/empty` (+0 -0) 📝 `molecule/framework-dependent/framework-dependent-app/framework-dependent-app.csproj` (+6 -1) 📝 `molecule/framework-dependent/molecule/default/tests/test_default.py` (+10 -0) 📝 `molecule/self-contained/molecule/default/tests/test_default.py` (+10 -0) 📝 `molecule/self-contained/self-contained-app/self-contained-app.csproj` (+6 -0) </details> ### 📄 Description Hidden and empty files are ignored because they generate rpmlint errors. Make sure the user knows about this, by generate a MSBuild warning. Fixes #60 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:31:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pending-validation
pull-request
Mirrored from GitHub Pull Request
 up-for-grabs
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?