[PR #167] [MERGED] Fix unit tests in CI #280

New Issue

claunia · 2026-01-29T16:31:48Z

claunia commented

2026-01-29 16:31:48 +00:00

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/167
Author: @qmfrederik
Created: 8/30/2020
Status: ✅ Merged
Merged: 8/30/2020
Merged by: @qmfrederik

Base: master ← Head: fixes/tests

📝 Commits (3)

6d06e1a Fix BouncyCastle version
f56e338 Run unit tests on .NET 5.0
4557a45 Bump test dependencies

📊 Changes

1 file changed (+6 additions, -7 deletions)

View changed files

📝 Packaging.Targets.Tests/Packaging.Targets.Tests.csproj (+6 -7)

📄 Description

Unit tests in CI were failing because they target netcoreapp3.1, yet CI runs on net5.0.

Have Packaging.Targets.Tests run on net5.0 and bump the test dependencies.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/167 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 8/30/2020 **Status:** ✅ Merged **Merged:** 8/30/2020 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `fixes/tests` --- ### 📝 Commits (3) - [`6d06e1a`](https://github.com/quamotion/dotnet-packaging/commit/6d06e1ab63a08a8818dc5a9880281b86603a852b) Fix BouncyCastle version - [`f56e338`](https://github.com/quamotion/dotnet-packaging/commit/f56e3387b45aa696f22509b33ac25553c6b6c193) Run unit tests on .NET 5.0 - [`4557a45`](https://github.com/quamotion/dotnet-packaging/commit/4557a45d93d7c95e5b98faf2b56419b57e7dc09b) Bump test dependencies ### 📊 Changes **1 file changed** (+6 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Packaging.Targets.Tests/Packaging.Targets.Tests.csproj` (+6 -7) </details> ### 📄 Description Unit tests in CI were failing because they target `netcoreapp3.1`, yet CI runs on `net5.0`. Have `Packaging.Targets.Tests` run on `net5.0` and bump the test dependencies. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:31:48 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#280