starred/dotnet-packaging
1
0
Fork 0
mirror of https://github.com/quamotion/dotnet-packaging.git synced 2026-02-04 05:35:40 +00:00
Code Issues 207 Packages Projects Releases Wiki Activity

[PR #236] Trim Debian install/remove scripts and fix line endings to Unix LF #316

New Issue
Open
opened 2026-01-29 16:32:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:32:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/236
Author: @andersemil
Created: 3/1/2023
Status: 🔄 Open

Base: master ← Head: fixes/deb-format-scripts

📝 Commits (1)

  • 35ac133 Trim Debian install/remove scripts and fix line endings to Unix LF

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 Packaging.Targets/Deb/DebPackageCreator.cs (+4 -4)

📄 Description

When creating a daemon for Linux, we needed to add a PostRemoveScript. When doing so, our programmer's Visual Studio was set to using CRLF line endings. Since scripts seem to be raw copied, this created invalid scripts for Linux systems.
We propose a fix by trimming the scripts and replacing CRLF line endings with LF.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/236 **Author:** [@andersemil](https://github.com/andersemil) **Created:** 3/1/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fixes/deb-format-scripts` --- ### 📝 Commits (1) - [`35ac133`](https://github.com/quamotion/dotnet-packaging/commit/35ac133440cc3b767bdacf283cb7694873a81782) Trim Debian install/remove scripts and fix line endings to Unix LF ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Packaging.Targets/Deb/DebPackageCreator.cs` (+4 -4) </details> ### 📄 Description When creating a daemon for Linux, we needed to add a PostRemoveScript. When doing so, our programmer's Visual Studio was set to using CRLF line endings. Since scripts seem to be raw copied, this created invalid scripts for Linux systems. We propose a fix by trimming the scripts and replacing CRLF line endings with LF. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:32:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pending-validation
pull-request
Mirrored from GitHub Pull Request
 up-for-grabs
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#316
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?