starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-08 07:14:31 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

CPU/Interpreter: Memory read failures are unlikely

Browse Source
This commit is contained in:
Stenzek
2025-09-21 16:57:46 +10:00
parent b106392da0
commit 0de2aafdb9
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/cpu_core.cpp
View File

@@ -1396,7 +1396,7 @@ restart_instruction:
}
u8 value;
if (!ReadMemoryByte(addr, &value))
if (!ReadMemoryByte(addr, &value)) [[unlikely]]
return;
const u32 sxvalue = SignExtend32(value);
@@ -1418,7 +1418,7 @@ restart_instruction:
}
u16 value;
if (!ReadMemoryHalfWord(addr, &value))
if (!ReadMemoryHalfWord(addr, &value)) [[unlikely]]
return;
const u32 sxvalue = SignExtend32(value);
@@ -1439,7 +1439,7 @@ restart_instruction:
}
u32 value;
if (!ReadMemoryWord(addr, &value))
if (!ReadMemoryWord(addr, &value)) [[unlikely]]
return;
WriteRegDelayed(inst.i.rt, value);
@@ -1459,7 +1459,7 @@ restart_instruction:
}
u8 value;
if (!ReadMemoryByte(addr, &value))
if (!ReadMemoryByte(addr, &value)) [[unlikely]]
return;
const u32 zxvalue = ZeroExtend32(value);
@@ -1480,7 +1480,7 @@ restart_instruction:
}
u16 value;
if (!ReadMemoryHalfWord(addr, &value))
if (!ReadMemoryHalfWord(addr, &value)) [[unlikely]]
return;
const u32 zxvalue = ZeroExtend32(value);
@@ -1503,7 +1503,7 @@ restart_instruction:
}
u32 aligned_value;
if (!ReadMemoryWord(aligned_addr, &aligned_value))
if (!ReadMemoryWord(aligned_addr, &aligned_value)) [[unlikely]]
return;
// Bypasses load delay. No need to check the old value since this is the delay slot or it's not relevant.
@@ -1592,7 +1592,7 @@ restart_instruction:
const u32 reg_value = ReadReg(inst.i.rt);
u32 mem_value;
if (!ReadMemoryWord(aligned_addr, &mem_value))
if (!ReadMemoryWord(aligned_addr, &mem_value)) [[unlikely]]
return;
if constexpr (pgxp_mode >= PGXPMode::Memory)