starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-12 09:24:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Achievements: Use rc_client_create_leaderboard_list() for hidden test

Browse Source 
That way it's compatible with external client.
This commit is contained in:
Stenzek
2026-01-17 14:32:49 +10:00
parent 3a0c4898ef
commit 2c8647d348
1 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/core/achievements.cpp
View File

@@ -1199,15 +1199,39 @@ void Achievements::ClientLoadGameCallback(int result, const char* error_message,
}
const bool has_achievements = rc_client_has_achievements(client);
const bool has_leaderboards = rc_client_has_leaderboards(client, false);
// Check for any non-hidden leaderboards. rc_client_create_leaderboard_list() filters hidden leaderboards.
const bool has_leaderboards_including_hidden = rc_client_has_leaderboards(client, true);
bool has_leaderboards = false;
if (rc_client_leaderboard_list_t* lblist;
has_leaderboards_including_hidden &&
(lblist = rc_client_create_leaderboard_list(client, RC_CLIENT_LEADERBOARD_LIST_GROUPING_NONE)))
{
for (u32 i = 0; i < lblist->num_buckets; ++i)
{
if (lblist->buckets[i].num_leaderboards > 0)
{
has_leaderboards = true;
break;
}
}
rc_client_destroy_leaderboard_list(lblist);
}
INFO_LOG("Game loaded: '{}' (ID: {}, Achievements: {}, Leaderboards: {})", info->title, info->id,
has_achievements ? "Yes" : "No", has_leaderboards ? "Yes" : "No");
// Only display summary if the game title has changed across discs.
const bool display_summary = (s_state.game_id != info->id || s_state.game_title != info->title);
// If the game has a RetroAchievements entry but no achievements or leaderboards, enforcing hardcore mode
// is pointless. Have to re-query leaderboards because hidden should still trip HC.
if (!has_achievements && !rc_client_has_leaderboards(client, true))
if (!has_achievements && !has_leaderboards_including_hidden)
{
WARNING_LOG("Game '{}' has no achievements or leaderboards, disabling hardcore mode.", info->title);
DisableHardcoreMode(false, false);
}
s_state.game_id = info->id;
s_state.game_title = info->title;