starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-05-21 07:26:42 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Qt: Failed to retrieve update change list is not fatal

Browse Source
This commit is contained in:
Stenzek
2025-12-14 00:35:25 +10:00
parent f248c1cd74
commit 4c384842ce
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/duckstation-qt/autoupdaterdialog.cpp
View File

@@ -454,6 +454,8 @@ void AutoUpdaterDialog::queueGetChanges()
void AutoUpdaterDialog::getChangesComplete(s32 status_code, const Error& error, std::vector<u8> response) void AutoUpdaterDialog::getChangesComplete(s32 status_code, const Error& error, std::vector<u8> response)
{ {
std::string_view error_message;
if (status_code == HTTPDownloader::HTTP_STATUS_OK) if (status_code == HTTPDownloader::HTTP_STATUS_OK)
{ {
QJsonParseError parse_error; QJsonParseError parse_error;
@@ -509,16 +511,23 @@ void AutoUpdaterDialog::getChangesComplete(s32 status_code, const Error& error,
} }
m_ui.updateNotes->setText(changes_html); m_ui.updateNotes->setText(changes_html);
return;
} }
else else
{ {
reportError("Change list JSON is not an object"); error_message = "Change list JSON is not an object";
} }
} }
else else
{ {
reportError(fmt::format("Failed to download change list: {}", error.GetDescription())); error_message = error.GetDescription();
} }
m_ui.updateNotes->setText(QString::fromStdString(
fmt::format("<h2>Failed to download change list</h2><p>The error was:<pre>{}</pre></p><p>You may be able to "
"install this update anyway. If the download installation fails, you can download the update "
"from:</p><p><a href=\"" DOWNLOAD_PAGE_URL "\">" DOWNLOAD_PAGE_URL "</a></p>",
error_message, UPDATER_RELEASE_CHANNEL, UPDATER_RELEASE_CHANNEL)));
} }
void AutoUpdaterDialog::downloadUpdateClicked() void AutoUpdaterDialog::downloadUpdateClicked()

6
src/duckstation-qt/autoupdaterdialog.ui
View File

@@ -114,7 +114,11 @@
</layout> </layout>
</item> </item>
<item> <item>
<widget class="QTextBrowser" name="updateNotes"/> <widget class="QTextBrowser" name="updateNotes">
<property name="openExternalLinks">
<bool>true</bool>
</property>
</widget>
</item> </item>
<item> <item>
<layout class="QHBoxLayout" name="actionButtons"> <layout class="QHBoxLayout" name="actionButtons">