diff --git a/src/core/fullscreenui_settings.cpp b/src/core/fullscreenui_settings.cpp index fe64b120c..7d6c06972 100644 --- a/src/core/fullscreenui_settings.cpp +++ b/src/core/fullscreenui_settings.cpp @@ -553,7 +553,7 @@ void FullscreenUI::BeginEffectBinding(SettingsInterface* bsi, InputBindingInfo:: { // vibration motors use a list to select const bool game_settings = IsEditingGameSettings(bsi); - const InputManager::DeviceEffectList effects = InputManager::EnumerateDeviceEffects(type); + InputManager::DeviceEffectList effects = InputManager::EnumerateDeviceEffects(type); if (effects.empty()) { ShowToast(OSDMessageType::Info, {}, FSUI_STR("No devices with vibration motors were detected.")); diff --git a/src/core/system.cpp b/src/core/system.cpp index a17cc3c3e..1e2306687 100644 --- a/src/core/system.cpp +++ b/src/core/system.cpp @@ -1835,9 +1835,10 @@ bool System::BootSystem(SystemBootParameters parameters, Error* error) { if ((!parameters.save_state.empty() || !exe_override.empty()) && Achievements::IsHardcoreModeActive()) { - Achievements::ConfirmHardcoreModeDisableAsync(parameters.save_state.empty() ? - TRANSLATE_SV("Achievements", "Resuming state") : - TRANSLATE_SV("Achievements", "Overriding executable"), + const std::string_view message = !parameters.save_state.empty() ? + TRANSLATE_SV("Achievements", "Resuming state") : + TRANSLATE_SV("Achievements", "Overriding executable"); + Achievements::ConfirmHardcoreModeDisableAsync(message, [parameters = std::move(parameters)](bool approved) mutable { if (approved) { @@ -2331,7 +2332,7 @@ bool System::GetFramePresentationParameters(GPUBackendFramePresentationParameter if (cap->GetVideoFPS() != s_state.video_frame_rate) [[unlikely]] { - const std::string next_capture_path = cap->GetNextCapturePath(); + std::string next_capture_path = cap->GetNextCapturePath(); const u32 video_width = cap->GetVideoWidth(); const u32 video_height = cap->GetVideoHeight(); INFO_LOG("Video frame rate changed, switching to new capture file {}", Path::GetFileName(next_capture_path)); diff --git a/src/duckstation-qt/graphicssettingswidget.cpp b/src/duckstation-qt/graphicssettingswidget.cpp index 7d5304fb6..8e8e9b46f 100644 --- a/src/duckstation-qt/graphicssettingswidget.cpp +++ b/src/duckstation-qt/graphicssettingswidget.cpp @@ -1050,7 +1050,7 @@ void GraphicsSettingsWidget::createAspectRatioSetting(QComboBox* const cb, QSpin separator->setVisible(is_custom_ar); denominator->setVisible(is_custom_ar); - const auto value_changed = [cb, numerator, separator, denominator, sif]() { + auto value_changed = [cb, numerator, separator, denominator, sif]() { std::optional value_to_save; const int index = cb->currentIndex(); bool is_custom = false; diff --git a/src/util/input_manager.cpp b/src/util/input_manager.cpp index 373f025d2..61019e6c2 100644 --- a/src/util/input_manager.cpp +++ b/src/util/input_manager.cpp @@ -154,7 +154,7 @@ static void UpdateContinuedVibration(); static void InternalPauseVibration(); static void InternalClearEffects(); static void GenerateRelativeMouseEvents(); -static void ReloadDevices(); +[[maybe_unused]] static void ReloadDevices(); static bool DoEventHook(InputBindingKey key, float value); static bool PreprocessEvent(InputBindingKey key, float value, GenericInputBinding generic_key);