starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-16 11:24:36 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Qt: Fix QAction memory leak on shutdown

Browse Source 
Would also leak if you changed languages.
This commit is contained in:
Stenzek
2025-11-21 02:04:39 +10:00
parent 654587ea38
commit 857a767898
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/duckstation-qt/mainwindow.cpp
View File

@@ -1901,37 +1901,35 @@ void MainWindow::setupAdditionalUi()
m_game_list_widget->getListView()->horizontalHeader()->sortIndicatorOrder();
QActionGroup* const column_group = new QActionGroup(m_ui.menuSortBy);
QActionGroup* const order_group = new QActionGroup(m_ui.menuSortBy);
for (int i = 0; i <= GameListModel::Column_LastVisible; i++)
{
QAction* const action =
new QAction(m_game_list_widget->getModel()->headerData(i, Qt::Horizontal, Qt::DisplayRole).toString());
QAction* const action = new QAction(
m_game_list_widget->getModel()->headerData(i, Qt::Horizontal, Qt::DisplayRole).toString(), column_group);
action->setCheckable(true);
action->setChecked(current_sort_column == i);
action->setData(i);
column_group->addAction(action);
m_ui.menuSortBy->addAction(action);
connect(action, &QAction::triggered, this, &MainWindow::onViewSortByActionTriggered);
}
m_ui.menuSortBy->addSeparator();
QAction* const ascending_action = new QAction(tr("&Ascending"));
QActionGroup* const order_group = new QActionGroup(m_ui.menuSortBy);
QAction* const ascending_action = new QAction(tr("&Ascending"), order_group);
ascending_action->setIcon(QIcon::fromTheme(QIcon::ThemeIcon::GoUp));
ascending_action->setCheckable(true);
ascending_action->setChecked(current_sort_order == Qt::AscendingOrder);
ascending_action->setObjectName(QStringLiteral("SortAscending"));
order_group->addAction(ascending_action);
m_ui.menuSortBy->addAction(ascending_action);
connect(ascending_action, &QAction::triggered, this, &MainWindow::onViewSortOrderActionTriggered);
QAction* const descending_action = new QAction(tr("&Descending"));
QAction* const descending_action = new QAction(tr("&Descending"), order_group);
descending_action->setIcon(QIcon::fromTheme(QIcon::ThemeIcon::GoDown));
descending_action->setCheckable(true);
descending_action->setChecked(current_sort_order == Qt::DescendingOrder);
descending_action->setObjectName(QStringLiteral("SortDescending"));
order_group->addAction(descending_action);
m_ui.menuSortBy->addAction(descending_action);
connect(descending_action, &QAction::triggered, this, &MainWindow::onViewSortOrderActionTriggered);
}