starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-17 11:54:35 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

CPU/PGXP: Make register writes more readable

Browse Source
This commit is contained in:
Stenzek
2025-10-09 21:52:05 +10:00
parent 05a58285aa
commit 8bce5b0a55
1 changed files with 25 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
src/core/cpu_pgxp.cpp
View File

@@ -61,6 +61,8 @@ enum : u32
#define SET_LOWORD(val, loword) ((static_cast<u32>(val) & 0xFFFF0000u) | static_cast<u32>(static_cast<u16>(loword)))
#define SET_HIWORD(val, hiword) ((static_cast<u32>(val) & 0x0000FFFFu) | (static_cast<u32>(hiword) << 16))
#define PGXP_GTE_REGISTER(field) g_state.pgxp_gte[offsetof(GTE::Regs, field) / sizeof(u32)]
static bool ShouldSavePGXPState();
static double f16Sign(double val);
@@ -79,9 +81,6 @@ static PGXPValue& ValidateAndGetRtValue(Instruction instr, u32 rtVal);
static PGXPValue& ValidateAndGetRsValue(Instruction instr, u32 rsVal);
static void SetRtValue(Instruction instr, const PGXPValue& val);
static void SetRtValue(Instruction instr, const PGXPValue& val, u32 rtVal);
static PGXPValue& GetSXY0();
static PGXPValue& GetSXY1();
static PGXPValue& GetSXY2();
static void PushScreenXYFIFO();
static PGXPValue* GetPtr(u32 addr);
@@ -133,6 +132,12 @@ static std::FILE* s_log;
void CPU::PGXP::Initialize()
{
// Just in case due to memory layout...
static_assert(&PGXP_GTE_REGISTER(SXY0) == &g_state.pgxp_gte[12]);
static_assert(&PGXP_GTE_REGISTER(SXY1) == &g_state.pgxp_gte[13]);
static_assert(&PGXP_GTE_REGISTER(SXY2) == &g_state.pgxp_gte[14]);
static_assert(&PGXP_GTE_REGISTER(SXYP) == &g_state.pgxp_gte[15]);
std::memset(g_state.pgxp_gpr, 0, sizeof(g_state.pgxp_gpr));
std::memset(g_state.pgxp_cop0, 0, sizeof(g_state.pgxp_cop0));
std::memset(g_state.pgxp_gte, 0, sizeof(g_state.pgxp_gte));
@@ -277,26 +282,11 @@ ALWAYS_INLINE void CPU::PGXP::SetRtValue(Instruction instr, const PGXPValue& val
prtVal.value = rtVal;
}
ALWAYS_INLINE CPU::PGXPValue& CPU::PGXP::GetSXY0()
{
return g_state.pgxp_gte[12];
}
ALWAYS_INLINE CPU::PGXPValue& CPU::PGXP::GetSXY1()
{
return g_state.pgxp_gte[13];
}
ALWAYS_INLINE CPU::PGXPValue& CPU::PGXP::GetSXY2()
{
return g_state.pgxp_gte[14];
}
ALWAYS_INLINE void CPU::PGXP::PushScreenXYFIFO()
{
g_state.pgxp_gte[12] = g_state.pgxp_gte[13]; // SXY0 = SXY1
g_state.pgxp_gte[13] = g_state.pgxp_gte[14]; // SXY1 = SXY2
g_state.pgxp_gte[14] = g_state.pgxp_gte[15]; // SXY2 = SXYP
PGXP_GTE_REGISTER(SXY0) = PGXP_GTE_REGISTER(SXY1); // SXY0 = SXY1
PGXP_GTE_REGISTER(SXY1) = PGXP_GTE_REGISTER(SXY2); // SXY1 = SXY2
PGXP_GTE_REGISTER(SXY2) = PGXP_GTE_REGISTER(SXYP); // SXY2 = SXYP
}
ALWAYS_INLINE_RELEASE CPU::PGXPValue* CPU::PGXP::GetPtr(u32 addr)
@@ -498,25 +488,25 @@ void CPU::PGXP::LogValueStr(SmallStringBase& str, const char* name, u32 rval, co
void CPU::PGXP::GTE_RTPS(float x, float y, float z, u32 value)
{
PGXPValue& pvalue = g_state.pgxp_gte[15];
pvalue.x = x;
pvalue.y = y;
pvalue.z = z;
pvalue.value = value;
pvalue.flags = VALID_ALL;
PGXPValue& SXYP = PGXP_GTE_REGISTER(SXYP);
SXYP.x = x;
SXYP.y = y;
SXYP.z = z;
SXYP.value = value;
SXYP.flags = VALID_ALL;
PushScreenXYFIFO();
if (g_settings.gpu_pgxp_vertex_cache)
CacheVertex(value, pvalue);
CacheVertex(value, SXYP);
}
bool CPU::PGXP::GTE_HasPreciseVertices(u32 sxy0, u32 sxy1, u32 sxy2)
{
PGXPValue& SXY0 = GetSXY0();
PGXPValue& SXY0 = PGXP_GTE_REGISTER(SXY0);
SXY0.Validate(sxy0);
PGXPValue& SXY1 = GetSXY1();
PGXPValue& SXY1 = PGXP_GTE_REGISTER(SXY1);
SXY1.Validate(sxy1);
PGXPValue& SXY2 = GetSXY2();
PGXPValue& SXY2 = PGXP_GTE_REGISTER(SXY2);
SXY2.Validate(sxy2);
// Don't use accurate clipping for game-constructed values, which don't have a valid Z.
@@ -525,9 +515,9 @@ bool CPU::PGXP::GTE_HasPreciseVertices(u32 sxy0, u32 sxy1, u32 sxy2)
float CPU::PGXP::GTE_NCLIP()
{
const PGXPValue& SXY0 = GetSXY0();
const PGXPValue& SXY1 = GetSXY1();
const PGXPValue& SXY2 = GetSXY2();
const PGXPValue& SXY0 = PGXP_GTE_REGISTER(SXY0);
const PGXPValue& SXY1 = PGXP_GTE_REGISTER(SXY1);
const PGXPValue& SXY2 = PGXP_GTE_REGISTER(SXY2);
float nclip = ((SXY0.x * SXY1.y) + (SXY1.x * SXY2.y) + (SXY2.x * SXY0.y) - (SXY0.x * SXY2.y) - (SXY1.x * SXY0.y) -
(SXY2.x * SXY1.y));
@@ -546,7 +536,7 @@ ALWAYS_INLINE_RELEASE void CPU::PGXP::CPU_MTC2(u32 reg, const PGXPValue& value,
case 15:
{
// push FIFO
g_state.pgxp_gte[15] = value;
PGXP_GTE_REGISTER(SXYP) = value;
PushScreenXYFIFO();
return;
}