starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-15 02:44:41 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Achievements: Fix "beaten" condition (#3506)

Browse Source 
Apparently there are sets (e.g. Colin McRae Rally) with zero
progression achievements.
This commit is contained in:
Davide Pesavento
2025-08-10 22:10:01 -04:00
committed by GitHub
parent de2d6d1aa0
commit 9576a3adf1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dep/rcheevos/src/rc_client.c
View File

@@ -976,9 +976,9 @@ static void rc_client_subset_get_user_game_summary(const rc_client_subset_info_t
}
/* Game considered beaten when all progression achievements are unlocked and any win condition achievement
* is unlocked, or all progression achievements are unlocked and no there are no win condition achievements. */
* is unlocked, or all progression achievements are unlocked and there are no win condition achievements. */
summary->beaten_time = 0;
if (num_progression_achievements > 0 && unlocked_progression_achievements == num_progression_achievements &&
if (unlocked_progression_achievements == num_progression_achievements &&
(num_win_condition_achievements == 0 || first_win_condition_unlock > 0)) {
summary->beaten_time = (num_win_condition_achievements == 0) ? last_progression_unlock : first_win_condition_unlock;
}