starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 13:14:31 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Achievements: Use OSD messages for errors instead of notifications

Browse Source
This commit is contained in:
Stenzek
2026-01-16 01:55:09 +10:00
parent 18768bcaba
commit bd44e36f70
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/core/achievements.cpp
View File

@@ -78,7 +78,6 @@ constexpr const char* const RA_LOGO_ICON_NAME = "images/ra-icon.webp";
static constexpr float LOGIN_NOTIFICATION_TIME = 5.0f;
static constexpr float ACHIEVEMENT_SUMMARY_NOTIFICATION_TIME = 5.0f;
static constexpr float ACHIEVEMENT_SUMMARY_NOTIFICATION_TIME_HC = 10.0f;
static constexpr float ACHIEVEMENT_SUMMARY_UNSUPPORTED_TIME = 12.0f;
static constexpr float GAME_COMPLETE_NOTIFICATION_TIME = 20.0f;
static constexpr float CHALLENGE_STARTED_NOTIFICATION_TIME = 5.0f;
static constexpr float CHALLENGE_FAILED_NOTIFICATION_TIME = 5.0f;
@@ -1307,11 +1306,11 @@ void Achievements::DisplayAchievementSummary()
if (s_state.game_summary.num_unsupported_achievements > 0)
{
FullscreenUI::AddAchievementNotification(
"UnsupportedAchievements", ACHIEVEMENT_SUMMARY_UNSUPPORTED_TIME, "images/warning.svg",
TRANSLATE_STR("Achievements", "Unsupported Achievements"),
TRANSLATE_PLURAL_STR("Achievements", "%n achievements are not supported by DuckStation.", "Achievement popup",
s_state.game_summary.num_unsupported_achievements));
Host::AddIconOSDMessage(OSDMessageType::Error, "UnsupportedAchievements", ICON_EMOJI_WARNING,
TRANSLATE_STR("Achievements", "Unsupported Achievements"),
TRANSLATE_PLURAL_STR("Achievements", "%n achievements are not supported by DuckStation.",
"Achievement popup",
s_state.game_summary.num_unsupported_achievements));
}
}
@@ -2080,8 +2079,8 @@ void Achievements::ClientLoginWithTokenCallback(int result, const char* error_me
// only display user error if they've started a game
if (System::IsValid())
{
FullscreenUI::AddAchievementNotification(
"AchievementsLoginFailed", 15.0f, "images/warning.svg",
Host::AddIconOSDMessage(
OSDMessageType::Error, "AchievementsLoginFailed", ICON_EMOJI_NO_ENTRY_SIGN,
TRANSLATE_STR("Achievements", "RetroAchievements Login Failed"),
fmt::format(
TRANSLATE_FS("Achievements", "Achievement unlocks will not be submitted for this session.\nError: {}"),