starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Qt: Don't use static storage for app icon

Browse Source 
Wastes TLS space apparently.
This commit is contained in:
Stenzek
2025-09-28 12:25:49 +10:00
parent daf5fee9ff
commit ea57a428f9
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/duckstation-qt/qthost.cpp
View File

@@ -140,6 +140,7 @@ struct State
INISettingsInterface base_settings_interface;
std::unique_ptr<QTimer> settings_save_timer;
std::vector<QTranslator*> translators;
QIcon app_icon;
QLocale app_locale;
std::once_flag roboto_font_once_flag;
QStringList roboto_font_families;
@@ -238,12 +239,16 @@ bool QtHost::EarlyProcessStartup()
qInstallMessageHandler(MessageOutputHandler);
Error error;
if (System::ProcessStartup(&error)) [[likely]]
return true;
if (!System::ProcessStartup(&error)) [[unlikely]]
{
QMessageBox::critical(nullptr, QStringLiteral("Process Startup Failed"),
QString::fromStdString(error.GetDescription()));
return false;
}
QMessageBox::critical(nullptr, QStringLiteral("Process Startup Failed"),
QString::fromStdString(error.GetDescription()));
return false;
// Load resources.
s_state.app_icon = QIcon(QStringLiteral(":/icons/duck.png"));
return true;
}
void QtHost::MessageOutputHandler(QtMsgType type, const QMessageLogContext& context, const QString& msg)
@@ -366,8 +371,7 @@ bool QtHost::SaveGameSettings(SettingsInterface* sif, bool delete_if_empty)
const QIcon& QtHost::GetAppIcon()
{
static const QIcon icon(QStringLiteral(":/icons/duck.png"));
return icon;
return s_state.app_icon;
}
std::optional<bool> QtHost::DownloadFile(QWidget* parent, const QString& title, std::string url, std::vector<u8>* data)