starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-15 10:54:36 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

Qt: Sync after creating widget on Linux

Browse Source 
We want to avoid nested event loops as much as possible because it's problematic on MacOS.
I removed the sync/processEvents() here for this reason, except of course fucking Linux throws
a wrench in the plan. On Windows and MacOS, calling show() and showFullscreen() will send resize
events with the correct size before returning. On Linux with X11 and Wankland, it doesn't.

So we have to force a processEvents() here to ensure the display widget is the correct size,
otherwise we'll see a glitched frame at the windowed size when starting fullscreen. Linux is
the odd one out again, as usual. Note: QGuiApplication::sync() is supposed to pump events
before and after syncing, but it seems this alone is not sufficient for getting the resize.
This commit is contained in:
Stenzek
2025-12-27 23:35:45 +10:00
parent a4657fbcbb
commit f07b726c67
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/duckstation-qt/mainwindow.cpp
View File

@@ -52,6 +52,7 @@
#include <QtCore/QUrl>
#include <QtGui/QActionGroup>
#include <QtGui/QCursor>
#include <QtGui/QGuiApplication>
#include <QtGui/QShortcut>
#include <QtGui/QWindowStateChangeEvent>
#include <QtWidgets/QFileDialog>
@@ -259,10 +260,16 @@ std::optional<WindowInfo> MainWindow::acquireRenderWindow(RenderAPI render_api,
}
else
{
container->showNormal();
restoreDisplayWindowGeometryFromConfig();
container->showNormal();
}
// See note below.
#if !defined(_WIN32) && !defined(__APPLE__)
QGuiApplication::sync();
QGuiApplication::processEvents(QEventLoop::ExcludeUserInputEvents);
#endif
updateDisplayRelatedActions();
updateDisplayWidgetCursor();
m_display_widget->setFocus();
@@ -275,6 +282,19 @@ std::optional<WindowInfo> MainWindow::acquireRenderWindow(RenderAPI render_api,
createDisplayWidget(fullscreen, render_to_main);
// We want to avoid nested event loops as much as possible because it's problematic on MacOS.
// I removed the sync/processEvents() here for this reason, except of course fucking Linux throws
// a wrench in the plan. On Windows and MacOS, calling show() and showFullscreen() will send resize
// events with the correct size before returning. On Linux with X11 and Wankland, it doesn't.
// So we have to force a processEvents() here to ensure the display widget is the correct size,
// otherwise we'll see a glitched frame at the windowed size when starting fullscreen. Linux is
// the odd one out again, as usual. Note: QGuiApplication::sync() is supposed to pump events
// before and after syncing, but it seems this alone is not sufficient for getting the resize.
#if !defined(_WIN32) && !defined(__APPLE__)
QGuiApplication::sync();
QGuiApplication::processEvents(QEventLoop::ExcludeUserInputEvents);
#endif
const std::optional<WindowInfo> wi = m_display_widget->getWindowInfo(render_api, error);
if (!wi.has_value())
{