[PR #2460] [MERGED] Fixed cheat type 52 only working with 1st subtype #1075

Closed
opened 2026-01-29 19:10:52 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2460
Author: @PugsyMAME
Created: 7/31/2021
Status: Merged
Merged: 8/7/2021
Merged by: @stenzek

Base: masterHead: master


📝 Commits (2)

  • 106dc29 Fixed cheat type 52 only working with 1st subtype
  • 7025cc3 Improved Cheat Memory Scanner functionality

📊 Changes

4 files changed (+200 additions, -55 deletions)

View changed files

📝 src/core/cheats.cpp (+1 -1)
📝 src/duckstation-qt/cheatmanagerdialog.cpp (+85 -32)
📝 src/duckstation-qt/cheatmanagerdialog.h (+4 -2)
📝 src/duckstation-qt/cheatmanagerdialog.ui (+110 -20)

📄 Description

Fixed typo in ExtCheatRegistersCompare, which made it so that only 52 type 5200 worked,


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2460 **Author:** [@PugsyMAME](https://github.com/PugsyMAME) **Created:** 7/31/2021 **Status:** ✅ Merged **Merged:** 8/7/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`106dc29`](https://github.com/stenzek/duckstation/commit/106dc2951d99b0e280e954ae04ff993f470fd819) Fixed cheat type 52 only working with 1st subtype - [`7025cc3`](https://github.com/stenzek/duckstation/commit/7025cc33821a09b773c8f5867ef57ca5588f65f9) Improved Cheat Memory Scanner functionality ### 📊 Changes **4 files changed** (+200 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `src/core/cheats.cpp` (+1 -1) 📝 `src/duckstation-qt/cheatmanagerdialog.cpp` (+85 -32) 📝 `src/duckstation-qt/cheatmanagerdialog.h` (+4 -2) 📝 `src/duckstation-qt/cheatmanagerdialog.ui` (+110 -20) </details> ### 📄 Description Fixed typo in ExtCheatRegistersCompare, which made it so that only 52 type 5200 worked, --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:10:52 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1075