[PR #2478] [MERGED] Improved Cheat Memory Scanner functionality #1083

Closed
opened 2026-01-29 19:10:57 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2478
Author: @PugsyMAME
Created: 8/6/2021
Status: Merged
Merged: 8/7/2021
Merged by: @stenzek

Base: masterHead: master


📝 Commits (1)

  • f835db6 Improved Cheat Memory Scanner functionality

📊 Changes

3 files changed (+199 additions, -54 deletions)

View changed files

📝 src/duckstation-qt/cheatmanagerdialog.cpp (+85 -32)
📝 src/duckstation-qt/cheatmanagerdialog.h (+4 -2)
📝 src/duckstation-qt/cheatmanagerdialog.ui (+110 -20)

📄 Description

Work done :
** Made the columns sortable (someone asked for this GH I think)
** Moved the Add to Watch button to under the search parameters, and renamed it.
** Made the selection work on a block level so we can block "add results" and block "Remove Watch" on multiple entries
** Made the description show the raw code - so either 3xxxxxxx, 8xxxxxxx, 9xxxxxxx depending on the Data Size and the memory being under 0x200000. This can be edited still.
** Changed the Watch value field to take a hex number in the form 0xX as well as a decimal number.
** Moved the freeze box to the right column, I originally did this prior to finding out about ContiguousSelection and I think it makes more sense next to the value you want to freeze
** Removed the message about 5000 results limitation (it made searching painful) and added a text box showing it permanently along with the number of results (which you can observe going down as you continue the search)
** Hidden the "Save Watch" & "Load Watch" buttons, they have no functionality (yet) and making them invisible in the mean time makes it less confusing.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2478 **Author:** [@PugsyMAME](https://github.com/PugsyMAME) **Created:** 8/6/2021 **Status:** ✅ Merged **Merged:** 8/7/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`f835db6`](https://github.com/stenzek/duckstation/commit/f835db6b4fe869f2cbb85035a11bd400a88e334b) Improved Cheat Memory Scanner functionality ### 📊 Changes **3 files changed** (+199 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/cheatmanagerdialog.cpp` (+85 -32) 📝 `src/duckstation-qt/cheatmanagerdialog.h` (+4 -2) 📝 `src/duckstation-qt/cheatmanagerdialog.ui` (+110 -20) </details> ### 📄 Description Work done : ** Made the columns sortable (someone asked for this GH I think) ** Moved the Add to Watch button to under the search parameters, and renamed it. ** Made the selection work on a block level so we can block "add results" and block "Remove Watch" on multiple entries ** Made the description show the raw code - so either 3xxxxxxx, 8xxxxxxx, 9xxxxxxx depending on the Data Size and the memory being under 0x200000. This can be edited still. ** Changed the Watch value field to take a hex number in the form 0xX as well as a decimal number. ** Moved the freeze box to the right column, I originally did this prior to finding out about ContiguousSelection and I think it makes more sense next to the value you want to freeze ** Removed the message about 5000 results limitation (it made searching painful) and added a text box showing it permanently along with the number of results (which you can observe going down as you continue the search) ** Hidden the "Save Watch" & "Load Watch" buttons, they have no functionality (yet) and making them invisible in the mean time makes it less confusing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:10:57 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1083