starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2538] [MERGED] Fix A0, A1, A2, A3 cheats #1098

New Issue
Open
opened 2026-01-29 19:11:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:11:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2538
Author: @CookiePLMonster
Created: 8/19/2021
Status: ✅ Merged
Merged: 8/21/2021
Merged by: @stenzek

Base: master ← Head: fix-32bit-cheats

📝 Commits (1)

  • ebe8625 Fix A0, A1, A2, A3 cheats

📊 Changes

1 file changed (+13 additions, -9 deletions)

View changed files

📝 src/core/cheats.cpp (+13 -9)

📄 Description

These 32-bit conditionals didn't really work, they were not registered as conditionals so were never marked to be skipped. The instruction pointer was instead set to the next line, the one these codes were supposed to skip (if false).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2538 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 8/19/2021 **Status:** ✅ Merged **Merged:** 8/21/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `fix-32bit-cheats` --- ### 📝 Commits (1) - [`ebe8625`](https://github.com/stenzek/duckstation/commit/ebe862561d2cfb2806cea89963b9a6e0ba7f7854) Fix A0, A1, A2, A3 cheats ### 📊 Changes **1 file changed** (+13 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/core/cheats.cpp` (+13 -9) </details> ### 📄 Description These 32-bit conditionals didn't really work, they were not registered as conditionals so were never marked to be skipped. The instruction pointer was instead set to the next line, the one these codes were supposed to skip (if false). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:11:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?