starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2555] [MERGED] Cheat list fixes #1101

New Issue
Open
opened 2026-01-29 19:11:06 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:11:06 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2555
Author: @CookiePLMonster
Created: 8/25/2021
Status: ✅ Merged
Merged: 9/1/2021
Merged by: @stenzek

Base: master ← Head: cheat-list-fixes

📝 Commits (2)

  • 6c70d7b Cheats: Call ApplyOnDisable on disabling cheats from the list
  • c7d0df6 Cheats: Update Cheat Manager state on toggling cheats from the list

📊 Changes

5 files changed (+18 additions, -6 deletions)

View changed files

📝 src/duckstation-qt/cheatmanagerdialog.cpp (+13 -6)
📝 src/duckstation-qt/cheatmanagerdialog.h (+1 -0)
📝 src/duckstation-qt/qthostinterface.cpp (+1 -0)
📝 src/duckstation-qt/qthostinterface.h (+1 -0)
📝 src/frontend-common/common_host_interface.cpp (+2 -0)

📄 Description

Fixes two bugs with the dropdown cheat list:

  1. Toggling cheats off from this list would not fire ApplyOnDisable, so it was inconsistent with the Cheat Manager.
  2. Toggling cheats on/off from this list would not update the visual state of the Cheat Manager.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2555 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 8/25/2021 **Status:** ✅ Merged **Merged:** 9/1/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `cheat-list-fixes` --- ### 📝 Commits (2) - [`6c70d7b`](https://github.com/stenzek/duckstation/commit/6c70d7b8b3873d2a34ca0b31874b51471446d379) Cheats: Call ApplyOnDisable on disabling cheats from the list - [`c7d0df6`](https://github.com/stenzek/duckstation/commit/c7d0df60814d41391973a63e6073d78a14735ea6) Cheats: Update Cheat Manager state on toggling cheats from the list ### 📊 Changes **5 files changed** (+18 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/cheatmanagerdialog.cpp` (+13 -6) 📝 `src/duckstation-qt/cheatmanagerdialog.h` (+1 -0) 📝 `src/duckstation-qt/qthostinterface.cpp` (+1 -0) 📝 `src/duckstation-qt/qthostinterface.h` (+1 -0) 📝 `src/frontend-common/common_host_interface.cpp` (+2 -0) </details> ### 📄 Description Fixes two bugs with the dropdown cheat list: 1. Toggling cheats off from this list would not fire `ApplyOnDisable`, so it was inconsistent with the Cheat Manager. 2. Toggling cheats on/off from this list would not update the visual state of the Cheat Manager. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:11:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?