[PR #2607] [MERGED] CommonHostInterface: Fix broken word wrap in DrawOSDMessages #1114

New Issue

claunia · 2026-01-29T19:11:11Z

claunia commented

2026-01-29 19:11:11 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2607
Author: @CookiePLMonster
Created: 9/13/2021
Status: ✅ Merged
Merged: 9/15/2021
Merged by: @stenzek

Base: master ← Head: osd-paths-fix

📝 Commits (1)

4fb39b6 CommonHostInterface: Fix broken word wrap in DrawOSDMessages

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/frontend-common/common_host_interface.cpp (+2 -2)

📄 Description

Fixes a regression introduced in e6ea6358a0 where long OSD messages did not calculate the rect size with word wrap in mind, but they tried to draw with wrap, resulting in messages cut off like so:

Now word wrap works as expected again:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2607 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 9/13/2021 **Status:** ✅ Merged **Merged:** 9/15/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `osd-paths-fix` --- ### 📝 Commits (1) - [`4fb39b6`](https://github.com/stenzek/duckstation/commit/4fb39b6d9ede9c666750150bad719460f0b05d87) CommonHostInterface: Fix broken word wrap in DrawOSDMessages ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/common_host_interface.cpp` (+2 -2) </details> ### 📄 Description Fixes a regression introduced in e6ea6358a00c0689d9c4345c4d522e7929c83d0a where long OSD messages did not calculate the rect size with word wrap in mind, but they tried to draw with wrap, resulting in messages cut off like so: ![image](https://user-images.githubusercontent.com/7947461/133154155-5240ea39-88b0-4495-abc6-a081d7dd9d61.png) Now word wrap works as expected again: ![image](https://user-images.githubusercontent.com/7947461/133154222-f98a406e-18f2-4867-a93d-cc36530f155a.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:11:11 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#1114