starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2602] [MERGED] GamePropertiesDialog: Unlock the CPU OC slider only when the option is #1115

New Issue
Open
opened 2026-01-29 19:11:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:11:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2602
Author: @CookiePLMonster
Created: 9/10/2021
Status: ✅ Merged
Merged: 9/15/2021
Merged by: @stenzek

Base: master ← Head: gamesettings-oc-tick

📝 Commits (1)

  • 9d537ba GamePropertiesDialog: Unlock the CPU OC slider only when the option is checked

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/duckstation-qt/gamepropertiesdialog.cpp (+3 -3)

📄 Description

A tiny UX fix - now the CPU overclock slider is unlocked only when the tri-state checkbox is checked (not partially checked). This reduces confusion and also makes sense from the perspective of how it works, as partially checked state is supposed to be a "don't care" state.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2602 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 9/10/2021 **Status:** ✅ Merged **Merged:** 9/15/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `gamesettings-oc-tick` --- ### 📝 Commits (1) - [`9d537ba`](https://github.com/stenzek/duckstation/commit/9d537ba03c87c5d67a247f65ac6ab65e970a62bf) GamePropertiesDialog: Unlock the CPU OC slider only when the option is checked ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/gamepropertiesdialog.cpp` (+3 -3) </details> ### 📄 Description A tiny UX fix - now the CPU overclock slider is unlocked only when the tri-state checkbox is checked (not partially checked). This reduces confusion and also makes sense from the perspective of how it works, as partially checked state is supposed to be a "don't care" state. ![image](https://user-images.githubusercontent.com/7947461/132886839-4a76e7cd-4f4c-4c7d-8f7b-0efefb2b126e.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:11:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1115
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?