starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2629] Update imgui to v1.85 (WIP) #1126

New Issue
Open
opened 2026-01-29 19:11:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:11:13 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/stenzek/duckstation/pull/2629

State: closed
Merged: No

Updates imgui to the current WIP of v1.85. Updates all of the
OpenGL/DX11/DX12/Vulkan backends to use the latest Imgui patterns.

This also fixes a Vulkan issue in particular regarding mapped memory not
being a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize.

[    8.5543] E(DebugMessengerCallback): Vulkan debug report: (VUID-VkMappedMemoryRange-size-01389) Validation Error: [ VUID-VkMappedMemoryRange-size-01389 ] Object 0: handle = 0xc84ae90000000996, type = VK_OBJECT_TYPE_DEVICE_MEMORY; | MessageID = 0xee4872d | vkFlushMappedMemoryRanges: Size in pMemRanges[0] is VK_WHOLE_SIZE and the mapping end (0x9df8 = 0x0 + 0x9df8) not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x40) and not equal to the end of the memory object (0x9e00). The Vulkan spec states: If size is equal to VK_WHOLE_SIZE, the end of the current mapping of memory must either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize bytes from the beginning of the memory object, or be equal to the end of the memory object (https://vulkan.lunarg.com/doc/view/1.2.176.1/windows/1.2-extensions/vkspec.html#VUID-VkMappedMemoryRange-size-01389)
**Original Pull Request:** https://github.com/stenzek/duckstation/pull/2629 **State:** closed **Merged:** No --- Updates imgui to the current WIP of v1.85. Updates all of the OpenGL/DX11/DX12/Vulkan backends to use the latest Imgui patterns. This also fixes a Vulkan issue in particular regarding mapped memory not being a multiple of `VkPhysicalDeviceLimits::nonCoherentAtomSize`. ``` [ 8.5543] E(DebugMessengerCallback): Vulkan debug report: (VUID-VkMappedMemoryRange-size-01389) Validation Error: [ VUID-VkMappedMemoryRange-size-01389 ] Object 0: handle = 0xc84ae90000000996, type = VK_OBJECT_TYPE_DEVICE_MEMORY; | MessageID = 0xee4872d | vkFlushMappedMemoryRanges: Size in pMemRanges[0] is VK_WHOLE_SIZE and the mapping end (0x9df8 = 0x0 + 0x9df8) not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x40) and not equal to the end of the memory object (0x9e00). The Vulkan spec states: If size is equal to VK_WHOLE_SIZE, the end of the current mapping of memory must either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize bytes from the beginning of the memory object, or be equal to the end of the memory object (https://vulkan.lunarg.com/doc/view/1.2.176.1/windows/1.2-extensions/vkspec.html#VUID-VkMappedMemoryRange-size-01389) ```
claunia added the pull-request label 2026-01-29 19:11:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?