starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2712] [MERGED] AnalogController: Fix legacy rumble conditions and implement status byte toggling #1145

New Issue
Open
opened 2026-01-29 19:11:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:11:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2712
Author: @ggrtk
Created: 11/7/2021
Status: ✅ Merged
Merged: 11/8/2021
Merged by: @stenzek

Base: master ← Head: analog-status-byte

📝 Commits (2)

  • ab496ef AnalogController: Don't re-enable legacy rumble on manual toggles
  • 3273ca3 AnalogController: Simulate status byte toggling

📊 Changes

3 files changed (+31 additions, -26 deletions)

View changed files

📝 src/core/analog_controller.cpp (+28 -21)
📝 src/core/analog_controller.h (+2 -4)
📝 src/core/save_state_version.h (+1 -1)

📄 Description

Just some really old commits from hardware testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2712 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 11/7/2021 **Status:** ✅ Merged **Merged:** 11/8/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `analog-status-byte` --- ### 📝 Commits (2) - [`ab496ef`](https://github.com/stenzek/duckstation/commit/ab496ef8fe6ff9cfc5292840d14e13bc0a35bf8d) AnalogController: Don't re-enable legacy rumble on manual toggles - [`3273ca3`](https://github.com/stenzek/duckstation/commit/3273ca36ef72deb271aa818a1e7ba8ccca9bc0fc) AnalogController: Simulate status byte toggling ### 📊 Changes **3 files changed** (+31 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/core/analog_controller.cpp` (+28 -21) 📝 `src/core/analog_controller.h` (+2 -4) 📝 `src/core/save_state_version.h` (+1 -1) </details> ### 📄 Description Just some really old commits from hardware testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:11:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1145
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?