starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2766] [MERGED] UI improvements #1162

New Issue
Closed
opened 2026-01-29 19:11:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:11:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2766
Author: @CookiePLMonster
Created: 12/13/2021
Status: ✅ Merged
Merged: 12/16/2021
Merged by: @stenzek

Base: master ← Head: ui-improvements

📝 Commits (2)

  • 690fa6e Memory Card Editor: Make fields not editable
  • 5d4622a Migrate most dialogs to use QDialogButtonBox

📊 Changes

15 files changed (+168 additions, -350 deletions)

View changed files

📝 src/duckstation-qt/achievementlogindialog.cpp (+8 -5)
📝 src/duckstation-qt/achievementlogindialog.h (+2 -0)
📝 src/duckstation-qt/achievementlogindialog.ui (+4 -17)
📝 src/duckstation-qt/cheatcodeeditordialog.cpp (+2 -2)
📝 src/duckstation-qt/cheatcodeeditordialog.ui (+5 -32)
📝 src/duckstation-qt/gamepropertiesdialog.cpp (+10 -7)
📝 src/duckstation-qt/gamepropertiesdialog.h (+3 -0)
📝 src/duckstation-qt/gamepropertiesdialog.ui (+5 -39)
📝 src/duckstation-qt/inputbindingdialog.ui (+0 -13)
📝 src/duckstation-qt/memorycardeditordialog.cpp (+39 -26)
📝 src/duckstation-qt/memorycardeditordialog.h (+12 -0)
📝 src/duckstation-qt/memorycardeditordialog.ui (+17 -140)
📝 src/duckstation-qt/postprocessingshaderconfigwidget.cpp (+7 -7)
📝 src/duckstation-qt/settingsdialog.cpp (+7 -2)
📝 src/duckstation-qt/settingsdialog.ui (+47 -60)

📄 Description

  1. Memory Card Editor fields were editable, but they shouldn't be.
  2. Migrated most QPushButtons to QDialogButtonBox. This cuts down on unneccessary translations, as Qt ones may now be used for common phrases like Close/Save/Apply/Restore Defaults, and additionally ensures Qt opts for platform's native button order/alignment.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2766 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 12/13/2021 **Status:** ✅ Merged **Merged:** 12/16/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `ui-improvements` --- ### 📝 Commits (2) - [`690fa6e`](https://github.com/stenzek/duckstation/commit/690fa6ec3cbf9c49cb5dd9a3cb7113399567b8df) Memory Card Editor: Make fields not editable - [`5d4622a`](https://github.com/stenzek/duckstation/commit/5d4622af9a37800b82d1068efc6308d01cf337c4) Migrate most dialogs to use QDialogButtonBox ### 📊 Changes **15 files changed** (+168 additions, -350 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/achievementlogindialog.cpp` (+8 -5) 📝 `src/duckstation-qt/achievementlogindialog.h` (+2 -0) 📝 `src/duckstation-qt/achievementlogindialog.ui` (+4 -17) 📝 `src/duckstation-qt/cheatcodeeditordialog.cpp` (+2 -2) 📝 `src/duckstation-qt/cheatcodeeditordialog.ui` (+5 -32) 📝 `src/duckstation-qt/gamepropertiesdialog.cpp` (+10 -7) 📝 `src/duckstation-qt/gamepropertiesdialog.h` (+3 -0) 📝 `src/duckstation-qt/gamepropertiesdialog.ui` (+5 -39) 📝 `src/duckstation-qt/inputbindingdialog.ui` (+0 -13) 📝 `src/duckstation-qt/memorycardeditordialog.cpp` (+39 -26) 📝 `src/duckstation-qt/memorycardeditordialog.h` (+12 -0) 📝 `src/duckstation-qt/memorycardeditordialog.ui` (+17 -140) 📝 `src/duckstation-qt/postprocessingshaderconfigwidget.cpp` (+7 -7) 📝 `src/duckstation-qt/settingsdialog.cpp` (+7 -2) 📝 `src/duckstation-qt/settingsdialog.ui` (+47 -60) </details> ### 📄 Description 1. Memory Card Editor fields were editable, but they shouldn't be. 2. Migrated most `QPushButton`s to `QDialogButtonBox`. This cuts down on unneccessary translations, as Qt ones may now be used for common phrases like Close/Save/Apply/Restore Defaults, and additionally ensures Qt opts for platform's native button order/alignment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:11:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?