[PR #2828] [MERGED] Add keys to more OSD messages #1192

New Issue

claunia · 2026-01-29T19:15:46Z

claunia commented

2026-01-29 19:15:46 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2828
Author: @CookiePLMonster
Created: 5/9/2022
Status: ✅ Merged
Merged: 5/13/2022
Merged by: @stenzek

Base: master ← Head: keyed-osd

📝 Commits (1)

3a70e4d Add keys to more OSD messages:

📊 Changes

3 files changed (+32 additions, -27 deletions)

View changed files

📝 src/core/gpu_hw.cpp (+9 -7)
📝 src/core/host_interface.cpp (+2 -2)
📝 src/frontend-common/common_host_interface.cpp (+21 -18)

📄 Description

The following actions, bindable to hotkeys, previously did not have keys for their OSD messages.

Resolution scale
Multisampling
Switching software/hardware rendering
Switching PGXP CPU
Switching post processing
Switching widescreen hack

This means that bashing hotkeys back and forth could result in spam like this, where all but the last message are meaningless:

This also makes behaviour more consistent as e.g. PGXP, PGXP depth buffer toggles already were keyed, but e.g. PGXP CPU was not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2828 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 5/9/2022 **Status:** ✅ Merged **Merged:** 5/13/2022 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `keyed-osd` --- ### 📝 Commits (1) - [`3a70e4d`](https://github.com/stenzek/duckstation/commit/3a70e4d57d033e926cc7089a311d069658753559) Add keys to more OSD messages: ### 📊 Changes **3 files changed** (+32 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/core/gpu_hw.cpp` (+9 -7) 📝 `src/core/host_interface.cpp` (+2 -2) 📝 `src/frontend-common/common_host_interface.cpp` (+21 -18) </details> ### 📄 Description The following actions, bindable to hotkeys, previously did not have keys for their OSD messages. * Resolution scale * Multisampling * Switching software/hardware rendering * Switching PGXP CPU * Switching post processing * Switching widescreen hack This means that bashing hotkeys back and forth could result in spam like this, where all but the last message are meaningless: ![image](https://user-images.githubusercontent.com/7947461/167503800-d3faf1fb-7fa2-47f0-8b2e-b3060503e45f.png) This also makes behaviour more consistent as e.g. PGXP, PGXP depth buffer toggles already were keyed, but e.g. PGXP CPU was not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:15:46 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#1192