starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2838] [MERGED] FullscreenUI: Untangle Escape button behaviour #1206

New Issue
Open
opened 2026-01-29 19:15:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:15:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2838
Author: @CookiePLMonster
Created: 7/23/2022
Status: ✅ Merged
Merged: 7/23/2022
Merged by: @stenzek

Base: master ← Head: pause-menu-fixes

📝 Commits (1)

  • 3040ce7 FullscreenUI: Untangle Escape button behaviour

📊 Changes

3 files changed (+19 additions, -15 deletions)

View changed files

📝 src/frontend-common/fullscreen_ui.cpp (+3 -1)
📝 src/frontend-common/imgui_fullscreen.cpp (+15 -12)
📝 src/frontend-common/imgui_fullscreen.h (+1 -2)

📄 Description

Now it doesn't race against Open Pause Menu, instead consistently backing out of menus on releasing Escape.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2838 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 7/23/2022 **Status:** ✅ Merged **Merged:** 7/23/2022 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `pause-menu-fixes` --- ### 📝 Commits (1) - [`3040ce7`](https://github.com/stenzek/duckstation/commit/3040ce7bbde918c7a6fc1096244f576c490f6b70) FullscreenUI: Untangle Escape button behaviour ### 📊 Changes **3 files changed** (+19 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/fullscreen_ui.cpp` (+3 -1) 📝 `src/frontend-common/imgui_fullscreen.cpp` (+15 -12) 📝 `src/frontend-common/imgui_fullscreen.h` (+1 -2) </details> ### 📄 Description Now it doesn't race against Open Pause Menu, instead consistently backing out of menus on releasing Escape. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:15:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1206
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?