starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2867] [MERGED] fix AchievementSummary/Notification font issue for ja/zh-cn #1249

New Issue
Open
opened 2026-01-29 19:16:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:16:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2867
Author: @Guwange
Created: 8/13/2022
Status: ✅ Merged
Merged: 8/18/2022
Merged by: @stenzek

Base: master ← Head: fix_notification_font_issue

📝 Commits (3)

  • ff09edf fix AchievementSummary/Notification font issue for ja/zh-cn
  • 01f0c1f fix OSD message about ChallengeMode to be translatable
  • 0d03aa2 generate GlyphRanges for ja/zh-cn based on *.ts files

📊 Changes

4 files changed (+97 additions, -11 deletions)

View changed files

➕ scripts/generate_update_glyph_ranges.py (+44 -0)
📝 src/duckstation-qt/qthost.cpp (+44 -2)
📝 src/frontend-common/achievements.cpp (+3 -2)
📝 src/frontend-common/imgui_manager.cpp (+6 -7)

📄 Description

This PR reverts imgui_manager.cpp modification made by below commit:

commit 853e9a8a6a
Author: Connor McLaughlin stenzek@gmail.com
Date: Fri Jul 22 21:51:00 2022 +1000

Qt: Fix updater

AchievementSummary (and Leaderboard submittion) uses Notification, and Notification is drawn using medium_font and large_font.
There are already some translations for AchievementSummary/Leaderboard.
This PR fixes issue that these translated messages are currently shown with ???? string.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2867 **Author:** [@Guwange](https://github.com/Guwange) **Created:** 8/13/2022 **Status:** ✅ Merged **Merged:** 8/18/2022 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `fix_notification_font_issue` --- ### 📝 Commits (3) - [`ff09edf`](https://github.com/stenzek/duckstation/commit/ff09edf3d79545419c19f70fc7cc9c90181488ec) fix AchievementSummary/Notification font issue for ja/zh-cn - [`01f0c1f`](https://github.com/stenzek/duckstation/commit/01f0c1ff3d164a3b9bd05a768bc8c4725ceeb79e) fix OSD message about ChallengeMode to be translatable - [`0d03aa2`](https://github.com/stenzek/duckstation/commit/0d03aa2b45c8fd81002193ab2962ec27f4261c0c) generate GlyphRanges for ja/zh-cn based on *.ts files ### 📊 Changes **4 files changed** (+97 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `scripts/generate_update_glyph_ranges.py` (+44 -0) 📝 `src/duckstation-qt/qthost.cpp` (+44 -2) 📝 `src/frontend-common/achievements.cpp` (+3 -2) 📝 `src/frontend-common/imgui_manager.cpp` (+6 -7) </details> ### 📄 Description This PR reverts imgui_manager.cpp modification made by below commit: ------------ commit 853e9a8a6a7234caeaa2ca75544375318cc86d68 Author: Connor McLaughlin <stenzek@gmail.com> Date: Fri Jul 22 21:51:00 2022 +1000 Qt: Fix updater ------------ AchievementSummary (and Leaderboard submittion) uses Notification, and Notification is drawn using medium_font and large_font. There are already some translations for AchievementSummary/Leaderboard. This PR fixes issue that these translated messages are currently shown with ???? string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:16:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?