starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #790] Fix a crash when changing controller backends as rumble changes #125

New Issue
Open
opened 2026-01-29 19:06:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:31 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/stenzek/duckstation/pull/790

State: closed
Merged: No

This PR promotes m_controller_interface from std::unique_ptr to std::shared_ptr to allow the rumble update callback not to call back to the interface if it has expired by holding onto a weak pointer.

This fixes a crash when changing controller backends as rumble is being updated. Rumble update callback attempted to call to a destroyed class, causing a crash. By holding onto a weak pointer instead, the callback can attempt to lock the weak pointer and gracefully handle failure.

Fixes #784

**Original Pull Request:** https://github.com/stenzek/duckstation/pull/790 **State:** closed **Merged:** No --- This PR promotes `m_controller_interface` from `std::unique_ptr` to `std::shared_ptr` to allow the rumble update callback not to call back to the interface if it has expired by holding onto a weak pointer. This fixes a crash when changing controller backends as rumble is being updated. Rumble update callback attempted to call to a destroyed class, causing a crash. By holding onto a weak pointer instead, the callback can attempt to lock the weak pointer and gracefully handle failure. Fixes #784
claunia added the pull-request label 2026-01-29 19:06:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?