starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2888] [MERGED] Fix "MSAA" and "SSAA" texts being swapped in enhancements overlay #1289

New Issue
Open
opened 2026-01-29 19:16:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:16:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2888
Author: @Calinou
Created: 9/22/2022
Status: ✅ Merged
Merged: 9/24/2022
Merged by: @stenzek

Base: master ← Head: enhancements-overlay-fix-swapped-msaa-ssaa

📝 Commits (1)

  • dcd11d8 Fix "MSAA" and "SSAA" texts being swapped in enhancements overlay

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/frontend-common/imgui_overlays.cpp (+1 -1)

📄 Description

Previously, when you selected MSAA in the advanced options, you got MSAA but the enhancements display showed "SSAA". The opposite happened when you selected SSAA.

(This checks out as per-sample shading refers to SSAA, while MSAA is only per-sample coverage.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2888 **Author:** [@Calinou](https://github.com/Calinou) **Created:** 9/22/2022 **Status:** ✅ Merged **Merged:** 9/24/2022 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `enhancements-overlay-fix-swapped-msaa-ssaa` --- ### 📝 Commits (1) - [`dcd11d8`](https://github.com/stenzek/duckstation/commit/dcd11d837178ec96f38b94b9f85d01533e9f958d) Fix "MSAA" and "SSAA" texts being swapped in enhancements overlay ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/imgui_overlays.cpp` (+1 -1) </details> ### 📄 Description Previously, when you selected MSAA in the advanced options, you got MSAA but the enhancements display showed "SSAA". The opposite happened when you selected SSAA. (This checks out as per-sample shading refers to SSAA, while MSAA is only per-sample *coverage*.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:16:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?