starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2928] [MERGED] Various fixes for the postprocessing controls in the fullscreen GUI #1347

New Issue
Closed
opened 2026-01-29 19:16:28 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:16:28 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2928
Author: @RSDuck
Created: 12/3/2022
Status: ✅ Merged
Merged: 12/4/2022
Merged by: @stenzek

Base: master ← Head: fullscreengui-fixes2

📝 Commits (1)

  • 527a1e6 Various fixes for the postprocessing controls in the fullscreen GUI

📊 Changes

1 file changed (+52 additions, -10 deletions)

View changed files

📝 src/frontend-common/fullscreen_ui.cpp (+52 -10)

📄 Description

  • Pushes the stage index as an ID so that the remove/move up/down buttons of different stages aren't treated as all the same.
  • Moves the modification of the post processing chain out of the loop (otherwise e.g. when deleting an item using a gamepad, all following items previously would have had the same index, resulting in the deletion of all following items).
  • As suggested use s_settings_changed to circumvent locking the already locked savefile lock (which is UB and a deadlock on Switch).
  • Add saving to a few actions after which it wouldn't save previously.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2928 **Author:** [@RSDuck](https://github.com/RSDuck) **Created:** 12/3/2022 **Status:** ✅ Merged **Merged:** 12/4/2022 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `fullscreengui-fixes2` --- ### 📝 Commits (1) - [`527a1e6`](https://github.com/stenzek/duckstation/commit/527a1e6d5ebf3915aa294060d60fcd56fdbe29a1) Various fixes for the postprocessing controls in the fullscreen GUI ### 📊 Changes **1 file changed** (+52 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/fullscreen_ui.cpp` (+52 -10) </details> ### 📄 Description * Pushes the stage index as an ID so that the remove/move up/down buttons of different stages aren't treated as all the same. * Moves the modification of the post processing chain out of the loop (otherwise e.g. when deleting an item using a gamepad, all following items previously would have had the same index, resulting in the deletion of all following items). * As suggested use s_settings_changed to circumvent locking the already locked savefile lock (which is UB and a deadlock on Switch). * Add saving to a few actions after which it wouldn't save previously. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:16:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?