[PR #2933] [MERGED] Prevent shutdown hotkey from bypassing the state on shutdown setting #1355

New Issue

claunia · 2026-01-29T19:16:30Z

claunia commented

2026-01-29 19:16:30 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2933
Author: @bslenul
Created: 12/18/2022
Status: ✅ Merged
Merged: 12/19/2022
Merged by: @stenzek

Base: master ← Head: shutdown-hk-state

📝 Commits (1)

266a50f Prevent shutdown hotkey from bypassing the state on shutdown setting

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/frontend-common/common_host.cpp (+1 -1)

📄 Description

Currently if you have "Save State on Shutdown" disabled, if you use the "Power Off" hotkey to close a game it will create a state anyway. I'm not sure if this is the best way to handle this, but with this PR it seems to work fine from my tests, and the state is not created if "Save State on Shutdown" is disabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2933 **Author:** [@bslenul](https://github.com/bslenul) **Created:** 12/18/2022 **Status:** ✅ Merged **Merged:** 12/19/2022 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `shutdown-hk-state` --- ### 📝 Commits (1) - [`266a50f`](https://github.com/stenzek/duckstation/commit/266a50f7bd1f37a5ec72ee5c0f4b15262b3e31ca) Prevent shutdown hotkey from bypassing the state on shutdown setting ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/common_host.cpp` (+1 -1) </details> ### 📄 Description Currently if you have "Save State on Shutdown" disabled, if you use the "Power Off" hotkey to close a game it will create a state anyway. I'm not sure if this is the best way to handle this, but with this PR it seems to work fine from my tests, and the state is not created if "Save State on Shutdown" is disabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:16:30 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#1355