[PR #2941] [MERGED] "Set Dumped VRAM Write Alpha Channel" should be true when resetting advanced settings #1365

New Issue

claunia · 2026-01-29T19:16:32Z

claunia commented

2026-01-29 19:16:32 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2941
Author: @bslenul
Created: 1/16/2023
Status: ✅ Merged
Merged: 1/17/2023
Merged by: @stenzek

Base: master ← Head: adv-settings-reset

📝 Commits (1)

4e42451 "Set Dumped VRAM Write Alpha Channel" should be true when clicking "Reset To Default"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/duckstation-qt/advancedsettingswidget.cpp (+1 -1)

📄 Description

Hey, currently when you click "Reset To Default" in the advanced settings, "Set Dumped VRAM Write Alpha Channel" will be disabled, I'm guessing this is a mistake since it's set to true everywhere else in the code by default.

There's also something wrong with the "PGXP Depth Clear Threshold" setting, if you start on a clean install (or if you delete "settings.ini"), it will be set to "4096" in the UI and "1228800" inside "settings.ini", but if you click "Reset To Default" it will be set to "300", which seems to be the desired value: 591e8b5b7a/src/core/settings.h (L430)

I'm not sure to understand why that setting is multiplied/divised by 4096: 591e8b5b7a/src/core/settings.h (L284-L291) so I don't want to mess with it, too afraid to break something :p I just wanted to warn you about this!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2941 **Author:** [@bslenul](https://github.com/bslenul) **Created:** 1/16/2023 **Status:** ✅ Merged **Merged:** 1/17/2023 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `adv-settings-reset` --- ### 📝 Commits (1) - [`4e42451`](https://github.com/stenzek/duckstation/commit/4e4245182b8c60b65831cf617579d9ad5e11dd94) "Set Dumped VRAM Write Alpha Channel" should be true when clicking "Reset To Default" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/advancedsettingswidget.cpp` (+1 -1) </details> ### 📄 Description Hey, currently when you click "Reset To Default" in the advanced settings, "Set Dumped VRAM Write Alpha Channel" will be disabled, I'm guessing this is a mistake since it's set to true everywhere else in the code by default. There's also something wrong with the "PGXP Depth Clear Threshold" setting, if you start on a clean install (or if you delete "settings.ini"), it will be set to "4096" in the UI and "1228800" inside "settings.ini", but if you click "Reset To Default" it will be set to "300", which seems to be the desired value: https://github.com/stenzek/duckstation/blob/591e8b5b7a9e1c503df5674b0b0d0203d7eef6a7/src/core/settings.h#L430 I'm not sure to understand why that setting is multiplied/divised by 4096: https://github.com/stenzek/duckstation/blob/591e8b5b7a9e1c503df5674b0b0d0203d7eef6a7/src/core/settings.h#L284-L291 so I don't want to mess with it, too afraid to break something :p I just wanted to warn you about this! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:16:32 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#1365