starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2942] [MERGED] CD-ROM fixes #1367

New Issue
Open
opened 2026-01-29 19:16:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:16:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2942
Author: @NicknineTheEagle
Created: 1/20/2023
Status: ✅ Merged
Merged: 1/20/2023
Merged by: @stenzek

Base: master ← Head: nn/cdrom

📝 Commits (2)

  • 7270531 CDROM: Fix region check
  • bd7517b CDROM: Try to reject non-PS1 discs

📊 Changes

2 files changed (+32 additions, -11 deletions)

View changed files

📝 src/core/cdrom.cpp (+31 -11)
📝 src/core/cdrom.h (+1 -0)

📄 Description

  • Fixed a bug where discs with unknown region would be accepted on US console even with region check enabled.
  • Added a check to try and reject non-PS1 discs as "unlicensed".

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2942 **Author:** [@NicknineTheEagle](https://github.com/NicknineTheEagle) **Created:** 1/20/2023 **Status:** ✅ Merged **Merged:** 1/20/2023 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `nn/cdrom` --- ### 📝 Commits (2) - [`7270531`](https://github.com/stenzek/duckstation/commit/7270531c3d94e21848a6b2f488dc47f845a29c78) CDROM: Fix region check - [`bd7517b`](https://github.com/stenzek/duckstation/commit/bd7517b0c952c8927be73201f610e485dc11e072) CDROM: Try to reject non-PS1 discs ### 📊 Changes **2 files changed** (+32 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/core/cdrom.cpp` (+31 -11) 📝 `src/core/cdrom.h` (+1 -0) </details> ### 📄 Description * Fixed a bug where discs with unknown region would be accepted on US console even with region check enabled. * Added a check to try and reject non-PS1 discs as "unlicensed". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:16:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?