mirror of
https://github.com/stenzek/duckstation.git
synced 2026-02-04 05:04:33 +00:00
[PR #2941] "Set Dumped VRAM Write Alpha Channel" should be true when resetting advanced settings #1369
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/stenzek/duckstation/pull/2941
State: closed
Merged: Yes
Hey, currently when you click "Reset To Default" in the advanced settings, "Set Dumped VRAM Write Alpha Channel" will be disabled, I'm guessing this is a mistake since it's set to true everywhere else in the code by default.
There's also something wrong with the "PGXP Depth Clear Threshold" setting, if you start on a clean install (or if you delete "settings.ini"), it will be set to "4096" in the UI and "1228800" inside "settings.ini", but if you click "Reset To Default" it will be set to "300", which seems to be the desired value:
591e8b5b7a/src/core/settings.h (L430)I'm not sure to understand why that setting is multiplied/divised by 4096:
591e8b5b7a/src/core/settings.h (L284-L291)so I don't want to mess with it, too afraid to break something :p I just wanted to warn you about this!