[PR #2953] [MERGED] Make Game Properties accessible from the toolbar #1389

Open
opened 2026-01-29 19:16:38 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2953
Author: @CookiePLMonster
Created: 2/28/2023
Status: Merged
Merged: 3/13/2023
Merged by: @stenzek

Base: masterHead: move-per-game-settings


📝 Commits (2)

  • f34b174 Qt: Move "Game Properties" from View to Settings
  • 6f0280a Qt: Add a context menu to the toolbar's Settings button when the game is running

📊 Changes

3 files changed (+43 additions, -3 deletions)

View changed files

📝 src/duckstation-qt/mainwindow.cpp (+17 -0)
📝 src/duckstation-qt/mainwindow.h (+4 -0)
📝 src/duckstation-qt/mainwindow.ui (+22 -3)

📄 Description

Port of https://github.com/PCSX2/pcsx2/pull/8297. Keeping as a draft until it's merged there, so in case something comes up in a review there I can fix this PR up.

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2953 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 2/28/2023 **Status:** ✅ Merged **Merged:** 3/13/2023 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `move-per-game-settings` --- ### 📝 Commits (2) - [`f34b174`](https://github.com/stenzek/duckstation/commit/f34b17446ce98665cb0ac78f0318d20bcf23e0af) Qt: Move "Game Properties" from View to Settings - [`6f0280a`](https://github.com/stenzek/duckstation/commit/6f0280afc2d3e15df7f5e56f8cc706ad29df86ae) Qt: Add a context menu to the toolbar's Settings button when the game is running ### 📊 Changes **3 files changed** (+43 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/mainwindow.cpp` (+17 -0) 📝 `src/duckstation-qt/mainwindow.h` (+4 -0) 📝 `src/duckstation-qt/mainwindow.ui` (+22 -3) </details> ### 📄 Description Port of https://github.com/PCSX2/pcsx2/pull/8297. Keeping as a draft until it's merged there, so in case something comes up in a review there I can fix this PR up. ![image](https://user-images.githubusercontent.com/7947461/221951719-f45e05d1-4ad1-4674-aaec-1440376d7b21.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:16:38 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1389