[PR #2978] [MERGED] Netplay: MAX_CONNECT_RETRIES peer to host connection attempts. #1427

New Issue

claunia · 2026-01-29T19:16:48Z

claunia commented

2026-01-29 19:16:48 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2978
Author: @HeatXD
Created: 5/15/2023
Status: ✅ Merged
Merged: 5/16/2023
Merged by: @stenzek

Base: netplay ← Head: netplay_connect_retries

📝 Commits (1)

d513b9d Netplay: MAX_CONNECT_RETRIES peer to host connection attempts.

📊 Changes

1 file changed (+21 additions, -5 deletions)

View changed files

📝 src/core/netplay.cpp (+21 -5)

📄 Description

We want to do this because the peer might have initiated a connection too early while the host was still setting up. this gives the connection MAX_CONNECT_RETRIES tries within MAX_CONNECT_TIME to establish the connection.

Before:

https://github.com/stenzek/duckstation/assets/45072324/96423393-d1b3-40df-9781-fd9ef67b32df

After:

https://github.com/stenzek/duckstation/assets/45072324/30da4429-18f1-4782-a3bc-cc5fdcf252a1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2978 **Author:** [@HeatXD](https://github.com/HeatXD) **Created:** 5/15/2023 **Status:** ✅ Merged **Merged:** 5/16/2023 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `netplay` ← **Head:** `netplay_connect_retries` --- ### 📝 Commits (1) - [`d513b9d`](https://github.com/stenzek/duckstation/commit/d513b9d7bafadaa71d060731f1bbaa1d8c862efb) Netplay: MAX_CONNECT_RETRIES peer to host connection attempts. ### 📊 Changes **1 file changed** (+21 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/core/netplay.cpp` (+21 -5) </details> ### 📄 Description We want to do this because the peer might have initiated a connection too early while the host was still setting up. this gives the connection MAX_CONNECT_RETRIES tries within MAX_CONNECT_TIME to establish the connection. Before: https://github.com/stenzek/duckstation/assets/45072324/96423393-d1b3-40df-9781-fd9ef67b32df After: https://github.com/stenzek/duckstation/assets/45072324/30da4429-18f1-4782-a3bc-cc5fdcf252a1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:16:48 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#1427