starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2982] Netplay / GGPO: Spectating up to 4 players #1430

New Issue
Closed
opened 2026-01-29 19:16:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:16:49 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/stenzek/duckstation/pull/2982

State: closed
Merged: Yes

The biggest bummer with this implementation is that the session has to be recreated when a spectator joins or leaves, which isn't ideal. in a ideal world it would allow spectators to join and leave without interrupting the ongoing session.

https://github.com/stenzek/duckstation/assets/45072324/427e0503-72e8-47be-923c-220b0dfa220f

**Original Pull Request:** https://github.com/stenzek/duckstation/pull/2982 **State:** closed **Merged:** Yes --- The biggest bummer with this implementation is that the session has to be recreated when a spectator joins ~~or leaves~~, which isn't ideal. in a ideal world it would allow spectators to join and leave without interrupting the ongoing session. https://github.com/stenzek/duckstation/assets/45072324/427e0503-72e8-47be-923c-220b0dfa220f
claunia added the pull-request label 2026-01-29 19:16:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?