[PR #2985] [MERGED] Netplay/Spectating: Drop spectator without having to reset #1432

New Issue

claunia · 2026-01-29T19:16:50Z

claunia commented

2026-01-29 19:16:50 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2985
Author: @HeatXD
Created: 7/8/2023
Status: ✅ Merged
Merged: 7/9/2023
Merged by: @stenzek

Base: netplay ← Head: drop_spectator_no_reset

📝 Commits (8)

8c6850a Update French translation
2d78b3f Merge pull request #2983 from Mateos81/french_translation
3ea0715 Update French translation
af5f1c7 Merge pull request #2984 from Mateos81/french_translation
ad39c92 gracefully leave as a spectator and don't crash due to ringbuffer.
ee28e7d check if you get stuck while spectating. if this is the case try to disconnect.
73d28ee Merge branch 'stenzek:master' into drop_spectator_no_reset
12bcd30 forgot to set this setting back to normal.

📊 Changes

5 files changed (+3214 additions, -2539 deletions)

View changed files

📝 dep/ggpo-x/src/backends/p2p.cpp (+5 -7)
📝 dep/ggpo-x/src/backends/spectator.cpp (+0 -7)
📝 dep/ggpo-x/src/network/udp_proto.cpp (+7 -1)
📝 src/core/netplay.cpp (+11 -4)
📝 src/duckstation-qt/translations/duckstation-qt_fr.ts (+3191 -2520)

📄 Description

applied a fix to the spectator send buffer to prevent form ggpo from crashing when a spectator leaves, which allows us to continue the session without having to reset.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2985 **Author:** [@HeatXD](https://github.com/HeatXD) **Created:** 7/8/2023 **Status:** ✅ Merged **Merged:** 7/9/2023 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `netplay` ← **Head:** `drop_spectator_no_reset` --- ### 📝 Commits (8) - [`8c6850a`](https://github.com/stenzek/duckstation/commit/8c6850aa428b6dbd29d0000c1c71e55fe1b44ccd) Update French translation - [`2d78b3f`](https://github.com/stenzek/duckstation/commit/2d78b3f26a18600cbeb1f7add97f345d7345deeb) Merge pull request #2983 from Mateos81/french_translation - [`3ea0715`](https://github.com/stenzek/duckstation/commit/3ea0715a484f95a96cb89189884f0529dbfd4669) Update French translation - [`af5f1c7`](https://github.com/stenzek/duckstation/commit/af5f1c711c80f0d34dacdbf801ba9d642c4f6932) Merge pull request #2984 from Mateos81/french_translation - [`ad39c92`](https://github.com/stenzek/duckstation/commit/ad39c921c882f7cf4572b5536feffed1e37af6f5) gracefully leave as a spectator and don't crash due to ringbuffer. - [`ee28e7d`](https://github.com/stenzek/duckstation/commit/ee28e7d8d0561331bac79588cf4bfa414d10bb22) check if you get stuck while spectating. if this is the case try to disconnect. - [`73d28ee`](https://github.com/stenzek/duckstation/commit/73d28eeddfd2649d22392898af43e5d3829519f1) Merge branch 'stenzek:master' into drop_spectator_no_reset - [`12bcd30`](https://github.com/stenzek/duckstation/commit/12bcd30843fa42f6d068af2441f1857efb9f790d) forgot to set this setting back to normal. ### 📊 Changes **5 files changed** (+3214 additions, -2539 deletions) <details> <summary>View changed files</summary> 📝 `dep/ggpo-x/src/backends/p2p.cpp` (+5 -7) 📝 `dep/ggpo-x/src/backends/spectator.cpp` (+0 -7) 📝 `dep/ggpo-x/src/network/udp_proto.cpp` (+7 -1) 📝 `src/core/netplay.cpp` (+11 -4) 📝 `src/duckstation-qt/translations/duckstation-qt_fr.ts` (+3191 -2520) </details> ### 📄 Description applied a fix to the spectator send buffer to prevent form ggpo from crashing when a spectator leaves, which allows us to continue the session without having to reset. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:16:50 +00:00

claunia closed this issue

2026-01-29 19:16:51 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#1432