starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #826] [MERGED] Ass a 256x256 app icon #147

New Issue
Open
opened 2026-01-29 19:06:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/826
Author: @CookiePLMonster
Created: 9/5/2020
Status: ✅ Merged
Merged: 9/6/2020
Merged by: @stenzek

Base: master ← Head: 256-icon

📝 Commits (1)

📊 Changes

2 files changed (+0 additions, -0 deletions)

View changed files

📝 src/duckstation-qt/duckstation-qt.ico (+0 -0)
📝 src/duckstation-sdl/duckstation-sdl.ico (+0 -0)

📄 Description

Windows can also use a 256x256 application icon for Large and Extra Large icons. Unlike smaller icons, this one is stored as a PNG so it doesn't explode the binary size.

Comparison between a new icon and an old icon, displayed at max icon size:
image

I have sourced the icon from a APP_ICON_DATA variable in code and cut it down from 260x260 to 256x256.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/826 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 9/5/2020 **Status:** ✅ Merged **Merged:** 9/6/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `256-icon` --- ### 📝 Commits (1) - [`2565d2c`](https://github.com/stenzek/duckstation/commit/2565d2cae125ae88b9e6355e5c49c489bb1a523e) Ass a 256x256 app icon ### 📊 Changes **2 files changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/duckstation-qt.ico` (+0 -0) 📝 `src/duckstation-sdl/duckstation-sdl.ico` (+0 -0) </details> ### 📄 Description Windows can also use a 256x256 application icon for Large and Extra Large icons. Unlike smaller icons, this one is stored as a PNG so it doesn't explode the binary size. Comparison between a new icon and an old icon, displayed at max icon size: ![image](https://user-images.githubusercontent.com/7947461/92313403-c920f000-efcb-11ea-8bc5-86610f0df1b7.png) I have sourced the icon from a `APP_ICON_DATA` variable in code and cut it down from 260x260 to 256x256. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:06:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#147
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?