starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #835] [MERGED] Upgrade region flags. Correct NTSC-U to NTSC-U/C. Add custom U/C flag. Remove outdated icons.qrc file. #153

New Issue
Open
opened 2026-01-29 19:06:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/835
Author: @TzakShrike
Created: 9/9/2020
Status: ✅ Merged
Merged: 9/9/2020
Merged by: @stenzek

Base: master ← Head: master

📝 Commits (2)

  • 0efd095 Remove mistakenly leftover icons.qrc file
  • 2ef6b6a Region flag upgrade & correct NTSC-U to NTSC-U/C

📊 Changes

18 files changed (+187 additions, -87 deletions)

View changed files

📝 src/core/settings.cpp (+2 -2)
📝 src/core/system.cpp (+1 -1)
📝 src/duckstation-libretro/libretro_host_interface.cpp (+1 -1)
📝 src/duckstation-qt/gamelistmodel.cpp (+1 -1)
➖ src/duckstation-qt/resources/icons.qrc (+0 -45)
📝 src/duckstation-qt/resources/icons/flag-eu.png (+0 -0)
📝 src/duckstation-qt/resources/icons/flag-eu.svg (+25 -23)
➕ src/duckstation-qt/resources/icons/flag-eu@2x.png (+0 -0)
📝 src/duckstation-qt/resources/icons/flag-jp.png (+0 -0)
📝 src/duckstation-qt/resources/icons/flag-jp.svg (+1 -0)
➕ src/duckstation-qt/resources/icons/flag-jp@2x.png (+0 -0)
➕ src/duckstation-qt/resources/icons/flag-uc.png (+0 -0)
➕ src/duckstation-qt/resources/icons/flag-uc.svg (+118 -0)
➕ src/duckstation-qt/resources/icons/flag-uc@2x.png (+0 -0)
📝 src/duckstation-qt/resources/icons/flag-us.png (+0 -0)
📝 src/duckstation-qt/resources/icons/flag-us.svg (+27 -11)
➕ src/duckstation-qt/resources/icons/flag-us@2x.png (+0 -0)
📝 src/duckstation-qt/resources/resources.qrc (+11 -3)

📄 Description

Replace references to NTSC-U with the correct NTSC-U/C and adds Canada in user-facing strings.
Replaces all region flags with revised SVGs.
Brings the US flag down to 3:2 to match Europe and Japan.
Adds a custom split US & Canada flag for the U/C region, also 3:2.
Generated PNGs and new HiDPI PNGs for region flags.
Flag PNGs were generated by downscaling using a Lanczos filter to a width of 36/72 pixels, then a 1px grey border added, then a 2/5px transparent border.
Removes resources/icons.qrc which was leftover from earlier development. It could cause compilation to fail if altering code related to older icons.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/835 **Author:** [@TzakShrike](https://github.com/TzakShrike) **Created:** 9/9/2020 **Status:** ✅ Merged **Merged:** 9/9/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`0efd095`](https://github.com/stenzek/duckstation/commit/0efd0953b189e8e8471dd02e58844419399382a4) Remove mistakenly leftover icons.qrc file - [`2ef6b6a`](https://github.com/stenzek/duckstation/commit/2ef6b6aa40e2a87d339c606a8ac380eed11dd64a) Region flag upgrade & correct NTSC-U to NTSC-U/C ### 📊 Changes **18 files changed** (+187 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `src/core/settings.cpp` (+2 -2) 📝 `src/core/system.cpp` (+1 -1) 📝 `src/duckstation-libretro/libretro_host_interface.cpp` (+1 -1) 📝 `src/duckstation-qt/gamelistmodel.cpp` (+1 -1) ➖ `src/duckstation-qt/resources/icons.qrc` (+0 -45) 📝 `src/duckstation-qt/resources/icons/flag-eu.png` (+0 -0) 📝 `src/duckstation-qt/resources/icons/flag-eu.svg` (+25 -23) ➕ `src/duckstation-qt/resources/icons/flag-eu@2x.png` (+0 -0) 📝 `src/duckstation-qt/resources/icons/flag-jp.png` (+0 -0) 📝 `src/duckstation-qt/resources/icons/flag-jp.svg` (+1 -0) ➕ `src/duckstation-qt/resources/icons/flag-jp@2x.png` (+0 -0) ➕ `src/duckstation-qt/resources/icons/flag-uc.png` (+0 -0) ➕ `src/duckstation-qt/resources/icons/flag-uc.svg` (+118 -0) ➕ `src/duckstation-qt/resources/icons/flag-uc@2x.png` (+0 -0) 📝 `src/duckstation-qt/resources/icons/flag-us.png` (+0 -0) 📝 `src/duckstation-qt/resources/icons/flag-us.svg` (+27 -11) ➕ `src/duckstation-qt/resources/icons/flag-us@2x.png` (+0 -0) 📝 `src/duckstation-qt/resources/resources.qrc` (+11 -3) </details> ### 📄 Description Replace references to NTSC-U with the correct NTSC-U/C and adds Canada in user-facing strings. Replaces all region flags with revised SVGs. Brings the US flag down to 3:2 to match Europe and Japan. Adds a custom split US & Canada flag for the U/C region, also 3:2. Generated PNGs and new HiDPI PNGs for region flags. Flag PNGs were generated by downscaling using a Lanczos filter to a width of 36/72 pixels, then a 1px grey border added, then a 2/5px transparent border. Removes resources/icons.qrc which was leftover from earlier development. It could cause compilation to fail if altering code related to older icons. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:06:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#153
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?