starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #844] [MERGED] Simplify quicksave/quickload logic #156

New Issue
Open
opened 2026-01-29 19:06:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:39 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/844
Author: @CookiePLMonster
Created: 9/12/2020
Status: ✅ Merged
Merged: 9/12/2020
Merged by: @stenzek

Base: master ← Head: fix-initial-savestate-hotkey

📝 Commits (1)

  • cf513c1 Simplify quicksave/quickload logic

📊 Changes

2 files changed (+16 additions, -17 deletions)

View changed files

📝 src/frontend-common/save_state_selector_ui.cpp (+15 -17)
📝 src/frontend-common/save_state_selector_ui.h (+1 -0)

📄 Description

Pressing F1/F2 to save/load state for the first time would do nothing because of the list refreshing code. An obvious fix would be not to return after calling RefreshList(); but upon closer examination, turns out the list is not required for quick saves/loads at all. This PR addresses the issue so the save state list is not populated upon save/load, and therefore fixes an aforementioned bug with the first save/load hotkey press.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/844 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 9/12/2020 **Status:** ✅ Merged **Merged:** 9/12/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `fix-initial-savestate-hotkey` --- ### 📝 Commits (1) - [`cf513c1`](https://github.com/stenzek/duckstation/commit/cf513c1c2400e9eba5556c9cc020faa62731c406) Simplify quicksave/quickload logic ### 📊 Changes **2 files changed** (+16 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/save_state_selector_ui.cpp` (+15 -17) 📝 `src/frontend-common/save_state_selector_ui.h` (+1 -0) </details> ### 📄 Description Pressing F1/F2 to save/load state for the first time would do nothing because of the list refreshing code. An obvious fix would be not to return after calling `RefreshList();` but upon closer examination, turns out the list is not required for quick saves/loads at all. This PR addresses the issue so the save state list is not populated upon save/load, and therefore fixes an aforementioned bug with the first save/load hotkey press. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:06:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?