starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #3076] [MERGED] DiscordRPC: Show session time in Discord Rich Presence #1566

New Issue
Open
opened 2026-01-29 19:17:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:17:27 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/3076
Author: @CookiePLMonster
Created: 12/23/2023
Status: ✅ Merged
Merged: 12/25/2023
Merged by: @stenzek

Base: master ← Head: discord-rpc

📝 Commits (2)

  • d08a40b DiscordRPC: Show session time in Discord Rich Presence
  • 8d491d3 System: Mark the VM as Stopping in ShutdownSystem unconditionally

📊 Changes

3 files changed (+13 additions, -10 deletions)

View changed files

📝 src/core/achievements.cpp (+1 -1)
📝 src/core/system.cpp (+11 -8)
📝 src/core/system.h (+1 -1)

📄 Description

This PR consists of two changes:

  1. Backport of https://github.com/PCSX2/pcsx2/pull/10397.
  2. Set s_state to State::Stopping unconditionally when shutting the game down. This fixes an issue where Discord RPC showed Unknown Game instead of No Game Running after shutting the game down.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/3076 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 12/23/2023 **Status:** ✅ Merged **Merged:** 12/25/2023 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `discord-rpc` --- ### 📝 Commits (2) - [`d08a40b`](https://github.com/stenzek/duckstation/commit/d08a40bcd8db1b0ae83609178e6aee18b85f9126) DiscordRPC: Show session time in Discord Rich Presence - [`8d491d3`](https://github.com/stenzek/duckstation/commit/8d491d3faa8363df31ab2b3cc31f62e575f61db1) System: Mark the VM as Stopping in ShutdownSystem unconditionally ### 📊 Changes **3 files changed** (+13 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/core/achievements.cpp` (+1 -1) 📝 `src/core/system.cpp` (+11 -8) 📝 `src/core/system.h` (+1 -1) </details> ### 📄 Description This PR consists of two changes: 1. Backport of https://github.com/PCSX2/pcsx2/pull/10397. 2. Set `s_state` to `State::Stopping` unconditionally when shutting the game down. This fixes an issue where Discord RPC showed `Unknown Game` instead of `No Game Running` after shutting the game down. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:17:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#1566
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?