[PR #848] [MERGED] More path fixes #162

New Issue

claunia · 2026-01-29T19:06:41Z

claunia commented

2026-01-29 19:06:41 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/848
Author: @CookiePLMonster
Created: 9/13/2020
Status: ✅ Merged
Merged: 9/15/2020
Merged by: @stenzek

Base: master ← Head: more-path-fixes

📝 Commits (2)

a35a283 Fix XML loading not handling UTF-8 paths
1918a5d STBI: Handle UTF-8 paths correctly

📊 Changes

4 files changed (+62 additions, -20 deletions)

View changed files

📝 src/common/image.cpp (+8 -1)
📝 src/core/gpu.cpp (+15 -3)
📝 src/core/host_display.cpp (+26 -12)
📝 src/frontend-common/game_list.cpp (+13 -4)

📄 Description

XML loading and screenshot/texture saving still couldn't handle UTF-8 on Windows.

NOTE: For screenshot saving, I had to define STBI_WINDOWS_UTF8 in multiple places (incl. stb project), is there a better way to do that? I probably also need to add the define to CMake somewhere?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/848 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 9/13/2020 **Status:** ✅ Merged **Merged:** 9/15/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `more-path-fixes` --- ### 📝 Commits (2) - [`a35a283`](https://github.com/stenzek/duckstation/commit/a35a2838b6bd2681d87d3ecd15b9fec2427bc968) Fix XML loading not handling UTF-8 paths - [`1918a5d`](https://github.com/stenzek/duckstation/commit/1918a5ddd4537115941093aac8c252a28fc35b2f) STBI: Handle UTF-8 paths correctly ### 📊 Changes **4 files changed** (+62 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/common/image.cpp` (+8 -1) 📝 `src/core/gpu.cpp` (+15 -3) 📝 `src/core/host_display.cpp` (+26 -12) 📝 `src/frontend-common/game_list.cpp` (+13 -4) </details> ### 📄 Description XML loading and screenshot/texture saving **still** couldn't handle UTF-8 on Windows. ~~**NOTE:** For screenshot saving, I had to define `STBI_WINDOWS_UTF8` in multiple places (incl. stb project), is there a better way to do that? I probably also need to add the define to CMake somewhere?~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:41 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#162