[PR #549] [MERGED] Qt: Simplify Rebind All behavior #17

New Issue

claunia · 2026-01-29T19:06:04Z

claunia commented

2026-01-29 19:06:04 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/549
Author: @ggrtk
Created: 6/15/2020
Status: ✅ Merged
Merged: 6/15/2020
Merged by: @stenzek

Base: master ← Head: qt-rebind-all

📝 Commits (2)

fd4e41b Qt: Simplify Rebind All behavior
1b9dbc1 Qt: Add help text note about binding rumble

📊 Changes

2 files changed (+15 additions, -10 deletions)

View changed files

📝 src/duckstation-qt/controllersettingswidget.cpp (+12 -8)
📝 src/duckstation-qt/settingsdialog.cpp (+3 -2)

📄 Description

The current behavior for Rebind All is to unconditionally rebind all buttons regardless of what the user selects in the question message box, with the selection only determining whether or not bindings are cleared before starting the full rebinding process. If Rebind All was pressed unintentionally, it seems that the user has to wait through the timeout process to prevent bindings from being changed.

To make this less prone to user error and more straightforward, Rebind All should first ask for user confirmation (like Clear All does), and if the user confirms, clear all bindings and run the rebinding.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/549 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 6/15/2020 **Status:** ✅ Merged **Merged:** 6/15/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `qt-rebind-all` --- ### 📝 Commits (2) - [`fd4e41b`](https://github.com/stenzek/duckstation/commit/fd4e41bc7d1fdd099903a4e4faac7c67aff77e21) Qt: Simplify Rebind All behavior - [`1b9dbc1`](https://github.com/stenzek/duckstation/commit/1b9dbc1a0b557bd7de3db754fb8803eb9448f611) Qt: Add help text note about binding rumble ### 📊 Changes **2 files changed** (+15 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/controllersettingswidget.cpp` (+12 -8) 📝 `src/duckstation-qt/settingsdialog.cpp` (+3 -2) </details> ### 📄 Description The current behavior for Rebind All is to unconditionally rebind all buttons regardless of what the user selects in the question message box, with the selection only determining whether or not bindings are cleared before starting the full rebinding process. If Rebind All was pressed unintentionally, it seems that the user has to wait through the timeout process to prevent bindings from being changed. To make this less prone to user error and more straightforward, Rebind All should first ask for user confirmation (like Clear All does), and if the user confirms, clear all bindings and run the rebinding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:04 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#17